Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Version 2 Release] resource/aws_instance: Remove deprecated network_interface_id attribute #7690

Closed
bflad opened this issue Feb 24, 2019 · 2 comments · Fixed by #7715
Closed

[Version 2 Release] resource/aws_instance: Remove deprecated network_interface_id attribute #7690

bflad opened this issue Feb 24, 2019 · 2 comments · Fixed by #7715
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone
v2.0.0

Comments

@bflad
Copy link
Contributor

bflad commented Feb 24, 2019

Description

Tracking issue for https://www.terraform.io/docs/providers/aws/guides/version-2-upgrade.html#resource-aws_instance

network_interface_id Attribute Removal

Switch your attribute references to the primary_network_interface_id attribute instead.
@bflad bflad added service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 24, 2019
@bflad bflad added this to the v2.0.0 milestone Feb 24, 2019
@bflad bflad mentioned this issue Feb 25, 2019
Merged
@bflad
Copy link
Contributor Author

bflad commented Feb 25, 2019

Pull request submitted: #7715

bflad added a commit that referenced this issue Feb 25, 2019
@bflad
resource/aws_instance: Remove deprecated top-level network_interface_…
6047825 
…id attribute

Reference: #7690

Output from acceptance testing:

```
--- PASS: TestAccAWSInstance_addSecondaryInterface (152.51s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (274.60s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (130.37s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (100.05s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (99.71s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (89.49s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (292.12s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (211.33s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (110.19s)
--- PASS: TestAccAWSInstance_basic (240.03s)
--- PASS: TestAccAWSInstance_blockDevices (178.54s)
--- PASS: TestAccAWSInstance_changeInstanceType (332.95s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (99.32s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (104.14s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (359.61s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (216.48s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (367.30s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (69.62s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (233.43s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (307.11s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (308.10s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (302.92s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (92.53s)
--- PASS: TestAccAWSInstance_disableApiTermination (151.40s)
--- PASS: TestAccAWSInstance_disappears (198.32s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (307.42s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (183.41s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (150.51s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (178.25s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (65.03s)
--- PASS: TestAccAWSInstance_importBasic (203.19s)
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgId (244.09s)
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgName (115.92s)
--- PASS: TestAccAWSInstance_importInEc2Classic (96.90s)
--- PASS: TestAccAWSInstance_instanceProfileChange (130.56s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (245.32s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (229.85s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (10.22s)
--- PASS: TestAccAWSInstance_keyPairCheck (184.07s)
--- PASS: TestAccAWSInstance_multipleRegions (239.75s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (70.36s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (84.93s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (69.24s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (171.04s)
--- PASS: TestAccAWSInstance_placementGroup (65.25s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (90.76s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (81.20s)
--- PASS: TestAccAWSInstance_privateIP (89.23s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (170.91s)
--- PASS: TestAccAWSInstance_rootInstanceStore (80.55s)
--- PASS: TestAccAWSInstance_sourceDestCheck (145.37s)
--- PASS: TestAccAWSInstance_tags (108.46s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (114.24s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (115.30s)
--- PASS: TestAccAWSInstance_userDataBase64 (234.15s)
--- PASS: TestAccAWSInstance_volumeTags (97.80s)
--- PASS: TestAccAWSInstance_volumeTagsComputed (109.57s)
--- PASS: TestAccAWSInstance_vpc (233.67s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (119.20s)
```
bflad added a commit that referenced this issue Feb 25, 2019
@bflad
resource/aws_instance: Remove deprecated top-level network_interface_…
9ccbc90 
…id attribute

Reference: #7690

Output from acceptance testing:

```
--- PASS: TestAccAWSInstance_addSecondaryInterface (152.51s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (274.60s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (130.37s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (100.05s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (99.71s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (89.49s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (292.12s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (211.33s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (110.19s)
--- PASS: TestAccAWSInstance_basic (240.03s)
--- PASS: TestAccAWSInstance_blockDevices (178.54s)
--- PASS: TestAccAWSInstance_changeInstanceType (332.95s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (99.32s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (104.14s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (359.61s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (216.48s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (367.30s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (69.62s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (233.43s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (307.11s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (308.10s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (302.92s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (92.53s)
--- PASS: TestAccAWSInstance_disableApiTermination (151.40s)
--- PASS: TestAccAWSInstance_disappears (198.32s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (307.42s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (183.41s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (150.51s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (178.25s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (65.03s)
--- PASS: TestAccAWSInstance_importBasic (203.19s)
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgId (244.09s)
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgName (115.92s)
--- PASS: TestAccAWSInstance_importInEc2Classic (96.90s)
--- PASS: TestAccAWSInstance_instanceProfileChange (130.56s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (245.32s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (229.85s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (10.22s)
--- PASS: TestAccAWSInstance_keyPairCheck (184.07s)
--- PASS: TestAccAWSInstance_multipleRegions (239.75s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (70.36s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (84.93s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (69.24s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (171.04s)
--- PASS: TestAccAWSInstance_placementGroup (65.25s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (90.76s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (81.20s)
--- PASS: TestAccAWSInstance_privateIP (89.23s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (170.91s)
--- PASS: TestAccAWSInstance_rootInstanceStore (80.55s)
--- PASS: TestAccAWSInstance_sourceDestCheck (145.37s)
--- PASS: TestAccAWSInstance_tags (108.46s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (114.24s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (115.30s)
--- PASS: TestAccAWSInstance_userDataBase64 (234.15s)
--- PASS: TestAccAWSInstance_volumeTags (97.80s)
--- PASS: TestAccAWSInstance_volumeTagsComputed (109.57s)
--- PASS: TestAccAWSInstance_vpc (233.67s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (119.20s)
```
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.0.0
1 participant
@bflad