Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging tests for resiliencehub #39804

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Tagging tests for resiliencehub #39804

wants to merge 5 commits into from

Conversation

gdavison
Copy link
Contributor

Description

Adds tagging tests for resiliencehub

Relations

Relates #38913

References

Output from Acceptance Testing

% make testacc PKG=resiliencehub TESTS=TestAccResilienceHubResiliencyPolicy_tags ACCTEST_PARALLELISM=10

--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nullOverlappingResourceTag (25.56s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnCreate (28.61s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_emptyProviderOnlyTag (29.31s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nullNonOverlappingResourceTag (30.65s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnUpdate_Replace (43.09s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_updateToResourceOnly (43.13s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_ComputedTag_OnUpdate_Add (43.20s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_emptyResourceTag (26.70s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_IgnoreTags_Overlap_DefaultTag (54.96s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_IgnoreTags_Overlap_ResourceTag (60.00s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnUpdate_Replace (50.04s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_updateToProviderOnly (50.51s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_EmptyMap (33.33s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_AddOnUpdate (50.93s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags (96.19s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_null (24.64s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_overlapping (75.66s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnCreate (52.24s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_nonOverlapping (71.41s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_EmptyTag_OnUpdate_Add (63.44s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags_DefaultTags_providerOnly (83.52s)

@gdavison gdavison requested a review from a team as a code owner October 18, 2024 22:37
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant