-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [New Resource] aws_resiliencehub_resiliency_policy #38913
Merged
gdavison
merged 34 commits into
hashicorp:main
from
coderaycer:f-resiliencehub-resiliency-policy
Oct 18, 2024
Merged
feat: [New Resource] aws_resiliencehub_resiliency_policy #38913
gdavison
merged 34 commits into
hashicorp:main
from
coderaycer:f-resiliencehub-resiliency-policy
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
Introduces or discusses updates to documentation.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
tags
Pertains to resource tagging.
generators
Relates to code generators.
service/resiliencehub
Issues and PRs that pertain to the resiliencehub service.
needs-triage
Waiting for first response or review from a maintainer.
labels
Aug 18, 2024
coderaycer
changed the title
feat: [new resource] aws_resiliencehub_resiliency_policy
feat: [New Resource] aws_resiliencehub_resiliency_policy
Aug 18, 2024
justinretzolk
added
new-resource
Introduces a new resource.
and removed
needs-triage
Waiting for first response or review from a maintainer.
labels
Aug 19, 2024
github-actions
bot
added
the
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
label
Oct 17, 2024
gdavison
force-pushed
the
f-resiliencehub-resiliency-policy
branch
from
October 18, 2024 19:59
19b9a71
to
36748a8
Compare
gdavison
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @coderaycer. I've made a number of changes, including:
- Changes to
policy
do not need to re-create the resource policy_description
andpolicy_name
have been renamed todescription
andname
- Removed the attribute
id
, sincearn
is the unique identifier - Updated the
basic
test to only set required attributes - Separated the attribute update tests to isolate changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
generators
Relates to code generators.
new-resource
Introduces a new resource.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/resiliencehub
Issues and PRs that pertain to the resiliencehub service.
tags
Pertains to resource tagging.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This resource will allow practitioners to create Resiliency Policies for Resilience Hub via Terraform.
Relations
Relates #38587
Relates #35803
References
https://docs.aws.amazon.com/resilience-hub/latest/APIReference/API_CreateResiliencyPolicy.html
Output from Acceptance Testing