Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [New Resource] aws_resiliencehub_resiliency_policy #38913

Merged
merged 34 commits into from
Oct 18, 2024

Conversation

coderaycer
Copy link
Contributor

Description

This resource will allow practitioners to create Resiliency Policies for Resilience Hub via Terraform.

Relations

Relates #38587
Relates #35803

References

https://docs.aws.amazon.com/resilience-hub/latest/APIReference/API_CreateResiliencyPolicy.html

Output from Acceptance Testing

make testacc TESTS=TestAccResilienceHubResiliencyPolicy_ PKG=resiliencehub
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/resiliencehub/... -v -count 1 -parallel 20 -run='TestAccResilienceHubResiliencyPolicy_'  -timeout 360m
=== RUN   TestAccResilienceHubResiliencyPolicy_basic
=== PAUSE TestAccResilienceHubResiliencyPolicy_basic
=== RUN   TestAccResilienceHubResiliencyPolicy_update
=== PAUSE TestAccResilienceHubResiliencyPolicy_update
=== RUN   TestAccResilienceHubResiliencyPolicy_tags
=== PAUSE TestAccResilienceHubResiliencyPolicy_tags
=== RUN   TestAccResilienceHubResiliencyPolicy_disappears
=== PAUSE TestAccResilienceHubResiliencyPolicy_disappears
=== CONT  TestAccResilienceHubResiliencyPolicy_basic
=== CONT  TestAccResilienceHubResiliencyPolicy_tags
=== CONT  TestAccResilienceHubResiliencyPolicy_disappears
=== CONT  TestAccResilienceHubResiliencyPolicy_update
--- PASS: TestAccResilienceHubResiliencyPolicy_disappears (22.21s)
--- PASS: TestAccResilienceHubResiliencyPolicy_basic (26.46s)
--- PASS: TestAccResilienceHubResiliencyPolicy_tags (50.57s)
--- PASS: TestAccResilienceHubResiliencyPolicy_update (84.96s)
PASS
ok

@coderaycer coderaycer requested a review from a team as a code owner August 18, 2024 17:33
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. needs-triage Waiting for first response or review from a maintainer. labels Aug 18, 2024
@coderaycer coderaycer changed the title feat: [new resource] aws_resiliencehub_resiliency_policy feat: [New Resource] aws_resiliencehub_resiliency_policy Aug 18, 2024
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 19, 2024
@gdavison gdavison self-assigned this Oct 17, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 17, 2024
@gdavison gdavison force-pushed the f-resiliencehub-resiliency-policy branch from 19b9a71 to 36748a8 Compare October 18, 2024 19:59
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @coderaycer. I've made a number of changes, including:

  • Changes to policy do not need to re-create the resource
  • policy_description and policy_name have been renamed to description and name
  • Removed the attribute id, since arn is the unique identifier
  • Updated the basic test to only set required attributes
  • Separated the attribute update tests to isolate changes

@gdavison gdavison merged commit 972f2ad into hashicorp:main Oct 18, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants