Fix RDS semgrep prefer-aws-go-sdk-pointer-conversion-conditional errors

.semgrep.yml

@@ -60,7 +60,6 @@ rules:
         - internal/service/elasticache
         - internal/service/elasticbeanstalk
         - internal/service/elb
-        - internal/service/rds
     patterns:
       - pattern-either:
         - pattern: '$LHS == *$RHS'

internal/service/rds/cluster.go

@@ -1460,7 +1460,7 @@ func resourceClusterStateRefreshFunc(conn *rds.RDS, dbClusterIdentifier string)
 		var dbc *rds.DBCluster
 
 		for _, c := range resp.DBClusters {
-			if *c.DBClusterIdentifier == dbClusterIdentifier {
+			if aws.StringValue(c.DBClusterIdentifier) == dbClusterIdentifier {
 				dbc = c
 			}
 		}

internal/service/rds/instance.go

@@ -1712,7 +1712,7 @@ func resourceInstanceUpdate(d *schema.ResourceData, meta interface{}) error {
 		req.StorageType = aws.String(d.Get("storage_type").(string))
 		requestUpdate = true
 
-		if *req.StorageType == "io1" {
+		if aws.StringValue(req.StorageType) == StorageTypeIo1 {
 			req.Iops = aws.Int64(int64(d.Get("iops").(int)))
 		}
 	}

internal/service/rds/option_group.go

@@ -191,7 +191,7 @@ func resourceOptionGroupRead(d *schema.ResourceData, meta interface{}) error {
 
 	var option *rds.OptionGroup
 	for _, ogl := range options.OptionGroupsList {
-		if *ogl.OptionGroupName == d.Id() {
+		if aws.StringValue(ogl.OptionGroupName) == d.Id() {
 			option = ogl
 			break
 		}
@@ -235,7 +235,7 @@ func resourceOptionGroupRead(d *schema.ResourceData, meta interface{}) error {
 
 func optionInList(optionName string, list []*string) bool {
 	for _, opt := range list {
-		if *opt == optionName {
+		if aws.StringValue(opt) == optionName {
 			return true
 		}
 	}

internal/service/rds/security_group.go

@@ -296,7 +296,7 @@ func resourceSecurityGroupRetrieve(d *schema.ResourceData, meta interface{}) (*r
 	}
 
 	if len(resp.DBSecurityGroups) != 1 ||
-		*resp.DBSecurityGroups[0].DBSecurityGroupName != d.Id() {
+		aws.StringValue(resp.DBSecurityGroups[0].DBSecurityGroupName) != d.Id() {
 		return nil, fmt.Errorf("Unable to find DB Security Group: %#v", resp.DBSecurityGroups)
 	}