Fix RDS semgrep prefer-aws-go-sdk-pointer-conversion-conditional errors

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #12992.

Fixes:

Findings:

  internal/service/rds/cluster.go 
     prefer-aws-go-sdk-pointer-conversion-conditional
        Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g.
        aws.StringValue()

       1463┆ if *c.DBClusterIdentifier == dbClusterIdentifier {


  internal/service/rds/instance.go 
     prefer-aws-go-sdk-pointer-conversion-conditional
        Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g.
        aws.StringValue()

       1715┆ if *req.StorageType == "io1" {


  internal/service/rds/option_group.go 
     prefer-aws-go-sdk-pointer-conversion-conditional
        Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g.
        aws.StringValue()

        194┆ if *ogl.OptionGroupName == d.Id() {
          ⋮┆----------------------------------------
        238┆ if *opt == optionName {


  internal/service/rds/security_group.go 
     prefer-aws-go-sdk-pointer-conversion-conditional
        Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g.
        aws.StringValue()

        299┆ *resp.DBSecurityGroups[0].DBSecurityGroupName != d.Id() {

% make testacc TESTARGS='-run=TestAccRDSCluster_basic\|TestAccRDSInstance_basic\|TestAccRDSOptionGroup_Option_optionSettings\|TestAccRDSSecurityGroup_basic' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_basic\|TestAccRDSInstance_basic\|TestAccRDSOptionGroup_Option_optionSettings\|TestAccRDSSecurityGroup_basic -timeout 180m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSOptionGroup_Option_optionSettings
=== PAUSE TestAccRDSOptionGroup_Option_optionSettings
=== RUN   TestAccRDSSecurityGroup_basic
=== PAUSE TestAccRDSSecurityGroup_basic
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSOptionGroup_Option_optionSettings
--- PASS: TestAccRDSOptionGroup_Option_optionSettings (33.75s)
=== CONT  TestAccRDSInstance_basic
--- PASS: TestAccRDSCluster_basic (172.16s)
=== CONT  TestAccRDSSecurityGroup_basic
--- PASS: TestAccRDSSecurityGroup_basic (17.75s)
--- PASS: TestAccRDSInstance_basic (530.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	568.846s

[github-actions]

This functionality has been released in v4.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.