Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bid_percentage argument description #21695

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

justinretzolk
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21691

Description

This PR corrects the description of the bid_percentage argument of the aws_batch_compute_environment

Saved you a click:

    // The maximum percentage that a Spot Instance price can be when compared with
    // the On-Demand price for that instance type before instances are launched.
    // For example, if your maximum percentage is 20%, then the Spot price must
    // be less than 20% of the current On-Demand price for that Amazon EC2 instance.
    // You always pay the lowest (market) price and never more than your maximum
    // percentage. If you leave this field empty, the default value is 100% of the
    // On-Demand price.
    //
    // This parameter isn't applicable to jobs that are running on Fargate resources,
    // and shouldn't be specified.

@justinretzolk justinretzolk added documentation Introduces or discusses updates to documentation. service/batch Issues and PRs that pertain to the batch service. labels Nov 9, 2021
@justinretzolk justinretzolk self-assigned this Nov 9, 2021
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Nov 9, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@justinretzolk justinretzolk merged commit 28e7337 into main Nov 9, 2021
@justinretzolk justinretzolk deleted the d-batch-bid-percentage branch November 9, 2021 19:30
@github-actions github-actions bot added this to the v3.65.0 milestone Nov 9, 2021
@github-actions
Copy link

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/batch Issues and PRs that pertain to the batch service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bid_percentage docs don't match console UI instructions
2 participants