bid_percentage docs don't match console UI instructions

[carlowahlstedt]

The docs for bid_percentage say:

bid_percentage - (Optional) Integer of minimum percentage that a Spot Instance price must be when compared with the On-Demand price for that instance type before instances are launched. For example, if your bid percentage is 20% (20), then the Spot price must be below 20% of the current On-Demand price for that EC2 instance. This parameter is required for SPOT compute environments. This parameter isn't applicable to jobs running on Fargate resources, and shouldn't be specified.

However the console UI says:

The maximum percentage of On-Demand pricing you want to pay for Spot resources. You will always pay the lowest Spot market price and never more than your maximum percentage. AWS Batch will use 100% as the default maximum price if you leave this field empty.

These seem to be opposite of one another and since the console behavior is the source of truth, the tf docs here should be updated to be in line with the console.

[justinretzolk]

Hey @carlowahlstedt 👋 Thank you for taking the time to open this issue and for bringing this to our attention! Looking over the Go SDK documentation, it looks like you're completely right:

// The maximum percentage that a Spot Instance price can be when compared with
// the On-Demand price for that instance type before instances are launched.
// For example, if your maximum percentage is 20%, then the Spot price must
// be less than 20% of the current On-Demand price for that Amazon EC2 instance.
// You always pay the lowest (market) price and never more than your maximum
// percentage. If you leave this field empty, the default value is 100% of the
// On-Demand price.
//
// This parameter isn't applicable to jobs that are running on Fargate resources,
// and shouldn't be specified.

I'll work on a pull request to get this updated (edit: I submitted the PR before this comment, but you get the picture 😛)

[github-actions]

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.