Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Transfer support for Microsoft Active Directory (AD) authentication #20851

Merged
merged 32 commits into from
Sep 10, 2021
Merged

AWS Transfer support for Microsoft Active Directory (AD) authentication #20851

merged 32 commits into from
Sep 10, 2021

Commits on Sep 9, 2021

  1. Start implementation of transfer access and transfer server active di… 

    …rectory type
    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    20a7e14 View commit details
    Browse the repository at this point in the history

  2. formatting

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    9f34b28 View commit details
    Browse the repository at this point in the history

  3. add test for transfer server with directory service

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    29961fe View commit details
    Browse the repository at this point in the history

  4. Create test file for transfer accesses and start implementation

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    58fbc09 View commit details
    Browse the repository at this point in the history

  5. tests for transfer accesses

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    c03acbf View commit details
    Browse the repository at this point in the history

  6. fix up todos

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    1d6c5c0 View commit details
    Browse the repository at this point in the history

  7. fixes

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e900be3 View commit details
    Browse the repository at this point in the history

  8. format

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    a6d5c8a View commit details
    Browse the repository at this point in the history

  9. resolve issues

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    649d5d5 View commit details
    Browse the repository at this point in the history

  10. Fix up tests

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    6d36be2 View commit details
    Browse the repository at this point in the history

  11. fix tests and bugs

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    7772c8f View commit details
    Browse the repository at this point in the history

  12. fix test data

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    2d300dc View commit details
    Browse the repository at this point in the history

  13. fix imports

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e10d4f1 View commit details
    Browse the repository at this point in the history

  14. Fix IDs missing on access update

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    094cebc View commit details
    Browse the repository at this point in the history

  15. fix fmt

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    41d3fe2 View commit details
    Browse the repository at this point in the history

  16. Fix changed SID in access test

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    137044d View commit details
    Browse the repository at this point in the history

  17. add changelog entry

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    30e13fb View commit details
    Browse the repository at this point in the history

  18. Fix role 'being changed' without role changing

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    3a273ae View commit details
    Browse the repository at this point in the history

  19. basic test for efs and s3 scope down policy

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    d04fb4d View commit details
    Browse the repository at this point in the history

  20. Extend documentation

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    42e5c98 View commit details
    Browse the repository at this point in the history

  21. refactor efs basic test

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    80929b3 View commit details
    Browse the repository at this point in the history

  22. fix terraform formatting in documentation

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e36b27b View commit details
    Browse the repository at this point in the history

  23. replace static arn partition with aws_partition datasource

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    38e90af View commit details
    Browse the repository at this point in the history

  24. remove deprecated interpolation only expressions

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    1aab832 View commit details
    Browse the repository at this point in the history

  25. terraform formatting

    @toriath @ewbankkit
    toriath authored and ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    bd3d99e View commit details
    Browse the repository at this point in the history

  26. r/aws_transfer_server: Add Directory Service PreChecks.

    @ewbankkit
    ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    88bd15b View commit details
    Browse the repository at this point in the history

  27. r/aws_transfer_access: Remove 'force-destroy' attribute.

    @ewbankkit
    ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    2ae911f View commit details
    Browse the repository at this point in the history

  28. Changes after rebase.

    @ewbankkit
    ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    c33ecda View commit details
    Browse the repository at this point in the history

  29. Fix terrafmt errors.

    @ewbankkit
    ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    ca7fbe4 View commit details
    Browse the repository at this point in the history

  30. r/aws_transfer_access: Role not returned via API. 

    Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSTransfer_serial/Access/S3Basic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSTransfer_serial/Access/S3Basic -timeout 180m
=== RUN   TestAccAWSTransfer_serial
=== RUN   TestAccAWSTransfer_serial/Access
=== RUN   TestAccAWSTransfer_serial/Access/S3Basic
--- PASS: TestAccAWSTransfer_serial (902.66s)
    --- PASS: TestAccAWSTransfer_serial/Access (902.66s)
        --- PASS: TestAccAWSTransfer_serial/Access/S3Basic (902.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	906.092s
    @ewbankkit
    ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    be4b4a1 View commit details
    Browse the repository at this point in the history

  31. Fix acceptance test configuration generation.

    @ewbankkit
    ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    7b5265c View commit details
    Browse the repository at this point in the history

  32. r/aws_transfer_server: Skip tests in GovCloud.

    @ewbankkit
    ewbankkit committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    114c757 View commit details
    Browse the repository at this point in the history