Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Transfer support for Microsoft Active Directory (AD) authentication #20851

Merged
merged 32 commits into from
Sep 10, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 9, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20017.
Supersedes #20342.

Output from acceptance testing:

Commercial

% ACCTEST_TIMEOUT=300m make testacc TEST=./aws TESTARGS='-run=TestAccAWSTransfer_serial'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSTransfer_serial -timeout 300m
=== RUN   TestAccAWSTransfer_serial
=== RUN   TestAccAWSTransfer_serial/SSHKey
=== RUN   TestAccAWSTransfer_serial/SSHKey/basic
=== RUN   TestAccAWSTransfer_serial/User
=== RUN   TestAccAWSTransfer_serial/User/Posix
=== RUN   TestAccAWSTransfer_serial/User/UserNameValidation
=== RUN   TestAccAWSTransfer_serial/User/basic
=== RUN   TestAccAWSTransfer_serial/User/disappears
=== RUN   TestAccAWSTransfer_serial/User/HomeDirectoryMappings
=== RUN   TestAccAWSTransfer_serial/User/ModifyWithOptions
=== RUN   TestAccAWSTransfer_serial/Access
=== RUN   TestAccAWSTransfer_serial/Access/S3Policy        
=== RUN   TestAccAWSTransfer_serial/Access/disappears
=== RUN   TestAccAWSTransfer_serial/Access/EFSBasic
=== RUN   TestAccAWSTransfer_serial/Access/S3Basic
=== RUN   TestAccAWSTransfer_serial/Server
=== RUN   TestAccAWSTransfer_serial/Server/DirectoryService
=== RUN   TestAccAWSTransfer_serial/Server/Protocols
=== RUN   TestAccAWSTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs
=== RUN   TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC
=== RUN   TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs
=== RUN   TestAccAWSTransfer_serial/Server/basic
=== RUN   TestAccAWSTransfer_serial/Server/HostKey
=== RUN   TestAccAWSTransfer_serial/Server/SecurityPolicy
=== RUN   TestAccAWSTransfer_serial/Server/UpdateEndpointTypePublicToVPC
=== RUN   TestAccAWSTransfer_serial/Server/VPC
=== RUN   TestAccAWSTransfer_serial/Server/ForceDestroy
=== RUN   TestAccAWSTransfer_serial/Server/APIGateway
=== RUN   TestAccAWSTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs
=== RUN   TestAccAWSTransfer_serial/Server/VPCSecurityGroupIDs
=== RUN   TestAccAWSTransfer_serial/Server/disappears
=== RUN   TestAccAWSTransfer_serial/Server/Domain
=== RUN   TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs
=== RUN   TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCToPublic
=== RUN   TestAccAWSTransfer_serial/Server/VPCAddressAllocationIDs
=== RUN   TestAccAWSTransfer_serial/Server/VPCEndpointID
=== RUN   TestAccAWSTransfer_serial/Server/APIGatewayForceDestroy
--- PASS: TestAccAWSTransfer_serial (10614.21s)
    --- PASS: TestAccAWSTransfer_serial/SSHKey (165.94s)
        --- PASS: TestAccAWSTransfer_serial/SSHKey/basic (165.94s)
    --- PASS: TestAccAWSTransfer_serial/User (1308.38s)
        --- PASS: TestAccAWSTransfer_serial/User/Posix (229.68s)
        --- PASS: TestAccAWSTransfer_serial/User/UserNameValidation (12.00s)
        --- PASS: TestAccAWSTransfer_serial/User/basic (187.64s)
        --- PASS: TestAccAWSTransfer_serial/User/disappears (186.19s)
        --- PASS: TestAccAWSTransfer_serial/User/HomeDirectoryMappings (483.92s)
        --- PASS: TestAccAWSTransfer_serial/User/ModifyWithOptions (208.95s)
    --- PASS: TestAccAWSTransfer_serial/Access (3722.40s)
        --- PASS: TestAccAWSTransfer_serial/Access/S3Policy (788.02s)
        --- PASS: TestAccAWSTransfer_serial/Access/disappears (992.27s)
        --- PASS: TestAccAWSTransfer_serial/Access/EFSBasic (971.90s)
        --- PASS: TestAccAWSTransfer_serial/Access/S3Basic (970.21s)
    --- PASS: TestAccAWSTransfer_serial/Server (5417.48s)
        --- PASS: TestAccAWSTransfer_serial/Server/DirectoryService (800.80s)
        --- PASS: TestAccAWSTransfer_serial/Server/Protocols (289.02s)
        --- PASS: TestAccAWSTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs (376.57s)
        --- PASS: TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC (205.61s)
        --- PASS: TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs (125.95s)
        --- PASS: TestAccAWSTransfer_serial/Server/basic (166.32s)
        --- PASS: TestAccAWSTransfer_serial/Server/HostKey (347.75s)
        --- PASS: TestAccAWSTransfer_serial/Server/SecurityPolicy (211.32s)
        --- PASS: TestAccAWSTransfer_serial/Server/UpdateEndpointTypePublicToVPC (310.75s)
        --- PASS: TestAccAWSTransfer_serial/Server/VPC (185.37s)
        --- PASS: TestAccAWSTransfer_serial/Server/ForceDestroy (347.14s)
        --- PASS: TestAccAWSTransfer_serial/Server/APIGateway (196.64s)
        --- PASS: TestAccAWSTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs (264.55s)
        --- PASS: TestAccAWSTransfer_serial/Server/VPCSecurityGroupIDs (89.00s)
        --- PASS: TestAccAWSTransfer_serial/Server/disappears (181.87s)
        --- PASS: TestAccAWSTransfer_serial/Server/Domain (185.94s)
        --- PASS: TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs (298.32s)
        --- PASS: TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCToPublic (247.34s)
        --- PASS: TestAccAWSTransfer_serial/Server/VPCAddressAllocationIDs (306.28s)
        --- PASS: TestAccAWSTransfer_serial/Server/VPCEndpointID (78.03s)
        --- PASS: TestAccAWSTransfer_serial/Server/APIGatewayForceDestroy (202.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10617.394s

GovCloud

% ACCTEST_TIMEOUT=300m make testacc TEST=./aws TESTARGS='-run=TestAccAWSTransfer_serial'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSTransfer_serial -timeout 300m
=== RUN   TestAccAWSTransfer_serial
=== RUN   TestAccAWSTransfer_serial/Access
=== RUN   TestAccAWSTransfer_serial/Access/disappears
    resource_aws_directory_service_directory_test.go:492: skipping acceptance testing: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: d4aa249b-41b7-4945-b198-e21f712c4f12 : RequestId: d4aa249b-41b7-4945-b198-e21f712c4f12
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "d4aa249b-41b7-4945-b198-e21f712c4f12"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: d4aa249b-41b7-4945-b198-e21f712c4f12 : RequestId: d4aa249b-41b7-4945-b198-e21f712c4f12",
          RequestId: "d4aa249b-41b7-4945-b198-e21f712c4f12"
        }
=== RUN   TestAccAWSTransfer_serial/Access/EFSBasic
    resource_aws_directory_service_directory_test.go:492: skipping acceptance testing: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 793ea1bf-975c-433f-bba4-a9ab95a483f4 : RequestId: 793ea1bf-975c-433f-bba4-a9ab95a483f4
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "793ea1bf-975c-433f-bba4-a9ab95a483f4"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 793ea1bf-975c-433f-bba4-a9ab95a483f4 : RequestId: 793ea1bf-975c-433f-bba4-a9ab95a483f4",
          RequestId: "793ea1bf-975c-433f-bba4-a9ab95a483f4"
        }
=== RUN   TestAccAWSTransfer_serial/Access/S3Basic
    resource_aws_directory_service_directory_test.go:492: skipping acceptance testing: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 06f49c3b-4f78-4d50-8e81-9e7cb20558fd : RequestId: 06f49c3b-4f78-4d50-8e81-9e7cb20558fd
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "06f49c3b-4f78-4d50-8e81-9e7cb20558fd"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 06f49c3b-4f78-4d50-8e81-9e7cb20558fd : RequestId: 06f49c3b-4f78-4d50-8e81-9e7cb20558fd",
          RequestId: "06f49c3b-4f78-4d50-8e81-9e7cb20558fd"
        }
=== RUN   TestAccAWSTransfer_serial/Access/S3Policy
    resource_aws_directory_service_directory_test.go:492: skipping acceptance testing: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 0dc700ab-5ce4-4578-93c6-5671f268056d : RequestId: 0dc700ab-5ce4-4578-93c6-5671f268056d
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "0dc700ab-5ce4-4578-93c6-5671f268056d"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 0dc700ab-5ce4-4578-93c6-5671f268056d : RequestId: 0dc700ab-5ce4-4578-93c6-5671f268056d",
          RequestId: "0dc700ab-5ce4-4578-93c6-5671f268056d"
        }
=== RUN   TestAccAWSTransfer_serial/Server
=== RUN   TestAccAWSTransfer_serial/Server/basic
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {}
        
=== RUN   TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running pre-apply refresh: exit status 1
        
        Error: error reading VPC Endpoint Service (com.amazonaws.us-gov-west-1.transfer.server): InvalidServiceName: The Vpc Endpoint Service 'com.amazonaws.us-gov-west-1.transfer.server' does not exist
        	status code: 400, request id: 9f203505-c510-4ff9-9abb-674c71fd9c91
        
          with data.aws_vpc_endpoint_service.test,
          on terraform_plugin_test.tf line 91, in data "aws_vpc_endpoint_service" "test":
          91: data "aws_vpc_endpoint_service" "test" {
        
=== RUN   TestAccAWSTransfer_serial/Server/VPC
=== RUN   TestAccAWSTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs
=== RUN   TestAccAWSTransfer_serial/Server/VPCEndpointID
    resource_aws_transfer_server_test.go:930: Transfer Server VPC_ENDPOINT endpoint type is not supported in GovCloud partition
=== RUN   TestAccAWSTransfer_serial/Server/DirectoryService
    resource_aws_directory_service_directory_test.go:492: skipping acceptance testing: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 9f84ba5e-a8ef-49c4-88fc-e59d77b67752 : RequestId: 9f84ba5e-a8ef-49c4-88fc-e59d77b67752
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "9f84ba5e-a8ef-49c4-88fc-e59d77b67752"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 9f84ba5e-a8ef-49c4-88fc-e59d77b67752 : RequestId: 9f84ba5e-a8ef-49c4-88fc-e59d77b67752",
          RequestId: "9f84ba5e-a8ef-49c4-88fc-e59d77b67752"
        }
=== RUN   TestAccAWSTransfer_serial/Server/Domain
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
=== RUN   TestAccAWSTransfer_serial/Server/HostKey
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
=== RUN   TestAccAWSTransfer_serial/Server/SecurityPolicy
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
=== RUN   TestAccAWSTransfer_serial/Server/UpdateEndpointTypePublicToVPC
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {}
        
=== RUN   TestAccAWSTransfer_serial/Server/disappears
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {}
        
=== RUN   TestAccAWSTransfer_serial/Server/APIGateway
    resource_aws_api_gateway_rest_api_test.go:1326: skipping test; Endpoint Configuration type EDGE is not supported in this partition (aws-us-gov)
=== RUN   TestAccAWSTransfer_serial/Server/ForceDestroy
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
=== RUN   TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running pre-apply refresh: exit status 1
        
        Error: error reading VPC Endpoint Service (com.amazonaws.us-gov-west-1.transfer.server): InvalidServiceName: The Vpc Endpoint Service 'com.amazonaws.us-gov-west-1.transfer.server' does not exist
        	status code: 400, request id: 4454ab45-788b-46bb-9fbf-f5821e652928
        
          with data.aws_vpc_endpoint_service.test,
          on terraform_plugin_test.tf line 91, in data "aws_vpc_endpoint_service" "test":
          91: data "aws_vpc_endpoint_service" "test" {
        
=== RUN   TestAccAWSTransfer_serial/Server/VPCAddressAllocationIDs
=== RUN   TestAccAWSTransfer_serial/Server/APIGatewayForceDestroy
    resource_aws_api_gateway_rest_api_test.go:1326: skipping test; Endpoint Configuration type EDGE is not supported in this partition (aws-us-gov)
=== RUN   TestAccAWSTransfer_serial/Server/Protocols
    resource_aws_api_gateway_rest_api_test.go:1326: skipping test; Endpoint Configuration type EDGE is not supported in this partition (aws-us-gov)
=== RUN   TestAccAWSTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {}
        
=== RUN   TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running pre-apply refresh: exit status 1
        
        Error: error reading VPC Endpoint Service (com.amazonaws.us-gov-west-1.transfer.server): InvalidServiceName: The Vpc Endpoint Service 'com.amazonaws.us-gov-west-1.transfer.server' does not exist
        	status code: 400, request id: e755f007-f93c-4aca-a992-ce6c37637524
        
          with data.aws_vpc_endpoint_service.test,
          on terraform_plugin_test.tf line 91, in data "aws_vpc_endpoint_service" "test":
          91: data "aws_vpc_endpoint_service" "test" {
        
=== RUN   TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCToPublic
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {}
        
=== RUN   TestAccAWSTransfer_serial/Server/VPCSecurityGroupIDs
=== RUN   TestAccAWSTransfer_serial/SSHKey
=== RUN   TestAccAWSTransfer_serial/SSHKey/basic
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
=== RUN   TestAccAWSTransfer_serial/User
=== RUN   TestAccAWSTransfer_serial/User/disappears
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
=== RUN   TestAccAWSTransfer_serial/User/HomeDirectoryMappings
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
=== RUN   TestAccAWSTransfer_serial/User/ModifyWithOptions
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
=== RUN   TestAccAWSTransfer_serial/User/Posix
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
=== RUN   TestAccAWSTransfer_serial/User/UserNameValidation
=== RUN   TestAccAWSTransfer_serial/User/basic
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          with aws_transfer_server.test,
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
--- PASS: TestAccAWSTransfer_serial (965.73s)
    --- PASS: TestAccAWSTransfer_serial/Access (5.95s)
        --- SKIP: TestAccAWSTransfer_serial/Access/disappears (2.56s)
        --- SKIP: TestAccAWSTransfer_serial/Access/EFSBasic (1.03s)
        --- SKIP: TestAccAWSTransfer_serial/Access/S3Basic (1.19s)
        --- SKIP: TestAccAWSTransfer_serial/Access/S3Policy (1.17s)
    --- PASS: TestAccAWSTransfer_serial/Server (875.14s)
        --- SKIP: TestAccAWSTransfer_serial/Server/basic (6.08s)
        --- SKIP: TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs (2.76s)
        --- PASS: TestAccAWSTransfer_serial/Server/VPC (196.78s)
        --- PASS: TestAccAWSTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs (229.09s)
        --- SKIP: TestAccAWSTransfer_serial/Server/VPCEndpointID (0.00s)
        --- SKIP: TestAccAWSTransfer_serial/Server/DirectoryService (1.20s)
        --- SKIP: TestAccAWSTransfer_serial/Server/Domain (5.99s)
        --- SKIP: TestAccAWSTransfer_serial/Server/HostKey (6.39s)
        --- SKIP: TestAccAWSTransfer_serial/Server/SecurityPolicy (6.16s)
        --- SKIP: TestAccAWSTransfer_serial/Server/UpdateEndpointTypePublicToVPC (6.25s)
        --- SKIP: TestAccAWSTransfer_serial/Server/disappears (6.18s)
        --- SKIP: TestAccAWSTransfer_serial/Server/APIGateway (0.00s)
        --- SKIP: TestAccAWSTransfer_serial/Server/ForceDestroy (11.54s)
        --- SKIP: TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs (2.84s)
        --- PASS: TestAccAWSTransfer_serial/Server/VPCAddressAllocationIDs (235.15s)
        --- SKIP: TestAccAWSTransfer_serial/Server/APIGatewayForceDestroy (0.00s)
        --- SKIP: TestAccAWSTransfer_serial/Server/Protocols (0.00s)
        --- SKIP: TestAccAWSTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs (6.18s)
        --- SKIP: TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC (2.93s)
        --- SKIP: TestAccAWSTransfer_serial/Server/UpdateEndpointTypeVPCToPublic (59.99s)
        --- PASS: TestAccAWSTransfer_serial/Server/VPCSecurityGroupIDs (89.62s)
    --- PASS: TestAccAWSTransfer_serial/SSHKey (11.14s)
        --- SKIP: TestAccAWSTransfer_serial/SSHKey/basic (11.14s)
    --- PASS: TestAccAWSTransfer_serial/User (73.50s)
        --- SKIP: TestAccAWSTransfer_serial/User/disappears (11.41s)
        --- SKIP: TestAccAWSTransfer_serial/User/HomeDirectoryMappings (11.41s)
        --- SKIP: TestAccAWSTransfer_serial/User/ModifyWithOptions (11.35s)
        --- SKIP: TestAccAWSTransfer_serial/User/Posix (11.51s)
        --- PASS: TestAccAWSTransfer_serial/User/UserNameValidation (16.21s)
        --- SKIP: TestAccAWSTransfer_serial/User/basic (11.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	969.031s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Sep 9, 2021
@github-actions github-actions bot added service/directoryservice service/transfer Issues and PRs that pertain to the transfer service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Sep 9, 2021
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSTransfer_serial/Access/S3Basic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSTransfer_serial/Access/S3Basic -timeout 180m
=== RUN   TestAccAWSTransfer_serial
=== RUN   TestAccAWSTransfer_serial/Access
=== RUN   TestAccAWSTransfer_serial/Access/S3Basic
--- PASS: TestAccAWSTransfer_serial (902.66s)
    --- PASS: TestAccAWSTransfer_serial/Access (902.66s)
        --- PASS: TestAccAWSTransfer_serial/Access/S3Basic (902.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	906.092s
@ewbankkit ewbankkit changed the title [WIP] AWS Transfer support for Microsoft Active Directory (AD) authentication AWS Transfer support for Microsoft Active Directory (AD) authentication Sep 9, 2021
@ewbankkit ewbankkit merged commit ad9c733 into main Sep 10, 2021
@ewbankkit ewbankkit deleted the tmp-pr20342 branch September 10, 2021 12:17
github-actions bot pushed a commit that referenced this pull request Sep 10, 2021
@breathingdust breathingdust added this to the v3.59.0 milestone Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/transfer Issues and PRs that pertain to the transfer service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Active Directory in AWS Transfer
3 participants