Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semgrep: add rule to enforce flattenStringSet when converting list of strings to Set #16651

Merged
merged 1 commit into from
Jan 11, 2021
Merged

semgrep: add rule to enforce flattenStringSet when converting list of strings to Set #16651

merged 1 commit into from
Jan 11, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Dec 8, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #6867

Release note for CHANGELOG:

N/A

Output from acceptance testing:

future CI warnings if applicable

@anGie44 anGie44 requested a review from a team as a code owner December 8, 2020 22:21
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Dec 8, 2020
@anGie44 anGie44 changed the title add rule to remove extraneous string list to set casting semgrep: add rule to remove extraneous []*string to *schema.Set conversion Dec 8, 2020
@anGie44 anGie44 changed the title semgrep: add rule to remove extraneous []*string to *schema.Set conversion semgrep: add rule to prevent extraneous []*string to *schema.Set conversion Dec 8, 2020
@anGie44 anGie44 changed the title semgrep: add rule to prevent extraneous []*string to *schema.Set conversion semgrep: add rule to enforce flattenStringSet when converting list of strings to Set Dec 8, 2020
@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Dec 8, 2020
@anGie44 anGie44 force-pushed the td-semgrep-check-extraneous-flattenList-rule branch from fec3308 to 09c1e2e Compare December 9, 2020 16:14
@anGie44 anGie44 force-pushed the td-semgrep-check-extraneous-flattenList-rule branch from 09c1e2e to f3fbd79 Compare December 9, 2020 16:15
gdavison
gdavison approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@anGie44 anGie44 added this to the v3.24.0 milestone Jan 11, 2021
@anGie44 anGie44 merged commit 40ef37d into master Jan 11, 2021
@anGie44 anGie44 deleted the td-semgrep-check-extraneous-flattenList-rule branch January 11, 2021 21:11
@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v3.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @gdavison