add rule to remove extraneous string list to set casting

hashicorp · Dec 8, 2020 · fec3308 · fec3308
1 parent cb4c3cf
commit fec3308
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/.semgrep.yml b/.semgrep.yml
@@ -36,6 +36,16 @@ rules:
           regex: '^"github.com/aws/aws-sdk-go/service/[^/]+"$'
     severity: WARNING
 
+  - id: helper-schema-Set-extraneous-NewSet-with-flattenStringList
+    languages: [go]
+    message: Prefer `flattenStringSet()` function for casting a list of string pointers to a set
+    paths:
+      include:
+        - aws/
+    patterns:
+      - pattern: schema.NewSet(schema.HashString, flattenStringList($APIOBJECT))
+    severity: WARNING
+
   - id: helper-schema-ResourceData-GetOk-with-extraneous-conditional
     languages: [go]
     message: Zero value conditional check after `d.GetOk()` is extraneous