Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/glue_catalog_database - plan time validations + read after create #15956

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 31, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7958

Release note for CHANGELOG:

resource_aws_glue_catalog_database - add plan time validations for `description` and `name`.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueCatalogDatabase_'
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (36.09s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (100.61s)
...

@DrFaust92 DrFaust92 requested a review from a team October 31, 2020 11:16
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. labels Oct 31, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 31, 2020
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCatalogDatabase_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogDatabase_ -timeout 120m
=== RUN   TestAccAWSGlueCatalogDatabase_full
=== PAUSE TestAccAWSGlueCatalogDatabase_full
=== RUN   TestAccAWSGlueCatalogDatabase_disappears
=== PAUSE TestAccAWSGlueCatalogDatabase_disappears
=== CONT  TestAccAWSGlueCatalogDatabase_full
=== CONT  TestAccAWSGlueCatalogDatabase_disappears
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (12.92s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (44.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	44.153s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCatalogDatabase_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogDatabase_ -timeout 120m
=== RUN   TestAccAWSGlueCatalogDatabase_full
=== PAUSE TestAccAWSGlueCatalogDatabase_full
=== RUN   TestAccAWSGlueCatalogDatabase_disappears
=== PAUSE TestAccAWSGlueCatalogDatabase_disappears
=== CONT  TestAccAWSGlueCatalogDatabase_full
=== CONT  TestAccAWSGlueCatalogDatabase_disappears
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (16.15s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (45.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	47.227s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCatalogDatabase_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogDatabase_ -timeout 120m
=== RUN   TestAccAWSGlueCatalogDatabase_full
=== PAUSE TestAccAWSGlueCatalogDatabase_full
=== RUN   TestAccAWSGlueCatalogDatabase_disappears
=== PAUSE TestAccAWSGlueCatalogDatabase_disappears
=== CONT  TestAccAWSGlueCatalogDatabase_full
=== CONT  TestAccAWSGlueCatalogDatabase_disappears
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (8.46s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (28.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.217s

@breathingdust breathingdust added this to the v3.14.0 milestone Nov 4, 2020
@breathingdust breathingdust merged commit 84d47fd into hashicorp:master Nov 4, 2020
breathingdust added a commit that referenced this pull request Nov 4, 2020
@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database name in aws_glue_catalog_database and aws_glue_catalog_table should be lowercase
3 participants