Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database name in aws_glue_catalog_database and aws_glue_catalog_table should be lowercase #7958

Closed
vitorbaptista opened this issue Mar 15, 2019 · 4 comments · Fixed by #15956
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/glue Issues and PRs that pertain to the glue service.
Milestone

Comments

@vitorbaptista
Copy link
Contributor

The AWS Glue documentation says:

To create a new database, choose Add database and provide a name and description. For compatibility with other metadata stores, such as Apache Hive, the name is folded to lowercase characters.

https://docs.aws.amazon.com/glue/latest/dg/console-databases.html

This means that, if there are uppercase letters in the database name, Terraform will always try to re-apply the changes because AWS automatically lower-cased the name specified in Terraform. In other words, the example in https://www.terraform.io/docs/providers/aws/r/glue_catalog_table.html won't ever converge.

It would also be nice if Terraform raised an error if the DB name wasn't lowercase-only.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. documentation Introduces or discusses updates to documentation. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/glue Issues and PRs that pertain to the glue service. labels Mar 15, 2019
@jukie
Copy link
Contributor

jukie commented Apr 11, 2019

I'd like to contribute to this, is there any concensus on the best way to handle this?
I think throwing an error is the simplest solution, but it could also be handled behind the scenes to always assume lowercase and check the lower case value of the name provided prior to determining if a change is needed.

@vitorbaptista
Copy link
Contributor Author

I'm not from Terraform's team, but as an user, I'd rather have Terraform throw an error and ask me to fix it than do so automatically. Explicit is better than implict.

@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
4 participants