Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech-debt: retrieve vpc limit for security group rules via Service Quota API #14209

Closed
wants to merge 2 commits into from
Closed

tech-debt: retrieve vpc limit for security group rules via Service Quota API #14209

wants to merge 2 commits into from

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jul 16, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14192
Might also be generalizable to AWS_EC2_CLIENT_VPN_LIMIT env var 🤔

Release note for CHANGELOG:

tech-debt: retrieve vpc quota limit for security group rules via Services Quota API

Output from acceptance testing:


...

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 16, 2020
@anGie44 anGie44 changed the title tech-debt: retrieve vpc limit for security group rules via Services Quota API tech-debt: retrieve vpc limit for security group rules via Service Quota API Jul 16, 2020
@anGie44 anGie44 force-pushed the td-security-group-rule-limit branch from fd7dc57 to 7006cef Compare July 16, 2020 17:29
@tomelliff tomelliff mentioned this pull request Sep 3, 2020
Closed
Base automatically changed from master to main January 23, 2021 00:58
@anGie44 anGie44 closed this Sep 29, 2021
@anGie44 anGie44 deleted the td-security-group-rule-limit branch September 29, 2021 15:55
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace or Augment EC2_SECURITY_GROUP_RULES_PER_GROUP_LIMIT Usage with Service Quotas Information
1 participant
@anGie44