Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace or Augment EC2_SECURITY_GROUP_RULES_PER_GROUP_LIMIT Usage with Service Quotas Information #14192

Closed
bflad opened this issue Jul 15, 2020 · 2 comments
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Comments

@bflad
Copy link
Contributor

bflad commented Jul 15, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Certain testing requires knowing account/region specific quotas about rules per EC2 Security Group. Currently the testing uses a default of 50 with an override via the EC2_SECURITY_GROUP_RULES_PER_GROUP_LIMIT environment variable. The Service Quotas service does provide this information, e.g.

        {
            "ServiceCode": "vpc",
            "ServiceName": "Amazon Virtual Private Cloud (Amazon VPC)",
            "QuotaArn": "arn:aws:servicequotas:us-west-2:--OMITTED--:vpc/L-0EA8095F",
            "QuotaCode": "L-0EA8095F",
            "QuotaName": "Inbound or outbound rules per security group",
            "Value": 60.0,
            "Unit": "None",
            "Adjustable": true,
            "GlobalQuota": false
        },

We should replace or augment the existing handling to try an automatically lookup the correct quota for the testing.

Affected Resource(s)

  • aws_security_group
@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Jul 15, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Jul 15, 2020
@anGie44 anGie44 self-assigned this Jul 15, 2020
@anGie44 anGie44 removed their assignment Sep 29, 2021
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label May 19, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants