r/aws_cloudtrail - support Tag on create

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10730 , Relates #10688

Release note for CHANGELOG:

resource/aws_cloudtrail: Support tag-on-create

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudTrail'
=== RUN   TestAccAWSCloudTrail
--- PASS: TestAccAWSCloudTrail (1697.63s)
=== RUN   TestAccAWSCloudTrail/Trail
    --- PASS: TestAccAWSCloudTrail/Trail (1697.63s)
=== RUN   TestAccAWSCloudTrail/Trail/basic
        --- PASS: TestAccAWSCloudTrail/Trail/basic (182.20s)
=== RUN   TestAccAWSCloudTrail/Trail/enableLogging
        --- PASS: TestAccAWSCloudTrail/Trail/enableLogging (247.37s)
=== RUN   TestAccAWSCloudTrail/Trail/includeGlobalServiceEvents
        --- PASS: TestAccAWSCloudTrail/Trail/includeGlobalServiceEvents (108.22s)
=== RUN   TestAccAWSCloudTrail/Trail/kmsKey
        --- PASS: TestAccAWSCloudTrail/Trail/kmsKey (131.58s)
=== RUN   TestAccAWSCloudTrail/Trail/tags
        --- PASS: TestAccAWSCloudTrail/Trail/tags (235.28s)
=== RUN   TestAccAWSCloudTrail/Trail/cloudwatch
        --- PASS: TestAccAWSCloudTrail/Trail/cloudwatch (190.19s)
=== RUN   TestAccAWSCloudTrail/Trail/isMultiRegion
        --- PASS: TestAccAWSCloudTrail/Trail/isMultiRegion (235.34s)
=== RUN   TestAccAWSCloudTrail/Trail/isOrganization
        --- SKIP: TestAccAWSCloudTrail/Trail/isOrganization (3.68s)
            provider_test.go:275: skipping tests; this AWS account must not be an existing member of an AWS Organization

Test ignored.
=== RUN   TestAccAWSCloudTrail/Trail/logValidation
        --- PASS: TestAccAWSCloudTrail/Trail/logValidation (177.57s)
=== RUN   TestAccAWSCloudTrail/Trail/eventSelector
        --- PASS: TestAccAWSCloudTrail/Trail/eventSelector (186.21s)

...

[gdavison]

LGTM.

Output from acceptance testing:

--- PASS: TestAccAWSCloudTrailServiceAccount_Region (8.13s)
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (8.14s)
--- PASS: TestAccAWSCloudTrail (218.56s)
    --- PASS: TestAccAWSCloudTrail/Trail (218.56s)
        --- PASS: TestAccAWSCloudTrail/Trail/cloudwatch (45.65s)
        --- PASS: TestAccAWSCloudTrail/Trail/enableLogging (22.49s)
        --- PASS: TestAccAWSCloudTrail/Trail/isMultiRegion (22.28s)
        --- SKIP: TestAccAWSCloudTrail/Trail/isOrganization (0.97s)
            provider_test.go:287: skipping tests; this AWS account must not be an existing member of an AWS Organization
        --- PASS: TestAccAWSCloudTrail/Trail/kmsKey (28.80s)
        --- PASS: TestAccAWSCloudTrail/Trail/basic (15.95s)
        --- PASS: TestAccAWSCloudTrail/Trail/includeGlobalServiceEvents (11.16s)
        --- PASS: TestAccAWSCloudTrail/Trail/logValidation (16.18s)
        --- PASS: TestAccAWSCloudTrail/Trail/tags (22.42s)
        --- PASS: TestAccAWSCloudTrail/Trail/eventSelector (32.65s)

[ghost]

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!