Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge #9

Merged
merged 7 commits into from
Nov 5, 2019
Merged

merge #9

merged 7 commits into from
Nov 5, 2019

Conversation

DrFaust92
Copy link
Owner

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

aeschright and others added 7 commits November 4, 2019 12:18
@aeschright
Delete PR triage Github Action (#10734)
dceb834 
Due to bug with unknown ETA https://github.community/t5/GitHub-Actions/Github-Workflow-not-running-from-pull-request-from-forked/td-p/32979
@bflad
Various hashibot labeling fixes/additions (#10732)
f5b1da3 
* provider: Hashibot issue/PR matching for CloudTrail should not include trailing underscore

Reference: #10730

The CloudTrail Trail resource is named just `aws_cloudtrail`.

* provider: Hashibot pull request labeling for route53resolver should include underscore

Reference: #10348

* provider: Add missing pull request labeling for qldb

Reference: #10394

* provider: Fix hashibot pull request labeling for athena

Reference: #10609

* provider: Ensure hashibot labeling for apigateway catches aws_api_gateway_vpc_link

Reference: #10561
@DrFaust92 @bflad
Refactor r/aws_acm_certificate to use keyvaluetags (#10733)
a5e7c55 
Output from acceptance testing:

```
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (17.29s)
--- PASS: TestAccAWSAcmCertificate_root (20.55s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (21.25s)
--- PASS: TestAccAWSAcmCertificate_privateCert (21.73s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (21.86s)
--- PASS: TestAccAWSAcmCertificate_wildcard (21.99s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (24.33s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (25.21s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (26.51s)
--- PASS: TestAccAWSAcmCertificate_san_single (26.64s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (26.77s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (26.99s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (28.61s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (28.80s)
--- PASS: TestAccAWSAcmCertificate_tags (40.02s)
```
@DrFaust92 @bflad
Keyvaluetags - add support for SQS & Cloudwatch Logs (#10740)
ad21374
@DrFaust92 @bflad
Refactor r/aws_acmpca_certificate_authority to use keyvaluetags (#10736)
ef3199e 
Output from acceptance test from AWS Commercial:

```
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Type_Root (10.15s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Basic (10.98s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays (26.15s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Tags (26.89s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled (32.01s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname (38.91s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Basic (6.80s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Type_Root (7.28s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays (13.45s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Tags (13.92s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled (16.07s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname (17.68s)
```
@bflad
Update CHANGELOG for #10736
e97a937
@DrFaust92 @bflad
refactor ami data source to use keyvaluetags (#10742)
f39af7f 
Output from acceptance testing:

```
--- PASS: TestAccAWSAmiDataSource_instanceStore (9.06s)
--- PASS: TestAccAWSAmiDataSource_natInstance (10.99s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (13.90s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (18.33s)
```
@DrFaust92 DrFaust92 merged commit 199b669 into DrFaust92:master Nov 5, 2019
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @aeschright @bflad