Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import for SSM association #10055

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Add import for SSM association #10055

merged 1 commit into from
Sep 18, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9981

Release note for CHANGELOG:

ENHANCEMENTS:
* resource/aws_ssm_association: Add import support

Output from acceptance testing:

$  make testacc TESTARGS="-run=TestAccAWSSSMAssociation_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSSMAssociation_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSSMAssociation_basic
=== PAUSE TestAccAWSSSMAssociation_basic
=== RUN   TestAccAWSSSMAssociation_withTargets
=== PAUSE TestAccAWSSSMAssociation_withTargets
=== RUN   TestAccAWSSSMAssociation_withParameters
=== PAUSE TestAccAWSSSMAssociation_withParameters
=== RUN   TestAccAWSSSMAssociation_withAssociationName
=== PAUSE TestAccAWSSSMAssociation_withAssociationName
=== RUN   TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression
=== PAUSE TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression
=== RUN   TestAccAWSSSMAssociation_withDocumentVersion
=== PAUSE TestAccAWSSSMAssociation_withDocumentVersion
=== RUN   TestAccAWSSSMAssociation_withOutputLocation
=== PAUSE TestAccAWSSSMAssociation_withOutputLocation
=== RUN   TestAccAWSSSMAssociation_withScheduleExpression
=== PAUSE TestAccAWSSSMAssociation_withScheduleExpression
=== RUN   TestAccAWSSSMAssociation_withComplianceSeverity
=== PAUSE TestAccAWSSSMAssociation_withComplianceSeverity
=== RUN   TestAccAWSSSMAssociation_rateControl
=== PAUSE TestAccAWSSSMAssociation_rateControl
=== CONT  TestAccAWSSSMAssociation_basic
=== CONT  TestAccAWSSSMAssociation_rateControl
=== CONT  TestAccAWSSSMAssociation_withScheduleExpression
=== CONT  TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression
=== CONT  TestAccAWSSSMAssociation_withComplianceSeverity
=== CONT  TestAccAWSSSMAssociation_withParameters
=== CONT  TestAccAWSSSMAssociation_withAssociationName
=== CONT  TestAccAWSSSMAssociation_withOutputLocation
=== CONT  TestAccAWSSSMAssociation_withTargets
=== CONT  TestAccAWSSSMAssociation_withDocumentVersion
--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (40.39s)
--- PASS: TestAccAWSSSMAssociation_withAssociationName (65.57s)
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (65.59s)
--- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (65.60s)
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (65.65s)
--- PASS: TestAccAWSSSMAssociation_withParameters (68.74s)
--- PASS: TestAccAWSSSMAssociation_rateControl (70.42s)
--- PASS: TestAccAWSSSMAssociation_withTargets (90.95s)
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (154.03s)
--- PASS: TestAccAWSSSMAssociation_basic (192.84s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       199.581s

Local screenshot of docs changes:
Screenshot 2019-09-10 at 11 44 57

@ryndaniels ryndaniels requested a review from a team September 10, 2019 09:56
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 10, 2019
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (31.12s)
--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (35.09s)
--- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (37.72s)
--- PASS: TestAccAWSSSMAssociation_withTargets (44.24s)
--- PASS: TestAccAWSSSMAssociation_withParameters (44.28s)
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (44.67s)
--- PASS: TestAccAWSSSMAssociation_rateControl (47.41s)
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (49.25s)
--- PASS: TestAccAWSSSMAssociation_withAssociationName (87.56s)
--- PASS: TestAccAWSSSMAssociation_basic (100.85s)

@ryndaniels ryndaniels merged commit 21c1ec6 into master Sep 18, 2019
@ryndaniels ryndaniels deleted the rfd-ssm-assn-import branch September 18, 2019 13:21
@nywilken nywilken added this to the v2.29.0 milestone Sep 20, 2019
@ghost
Copy link

ghost commented Sep 20, 2019

This has been released in version 2.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ssm_association doesn't support import
3 participants