Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopting aws_default_security_group does not update tags #14631

Closed
gdavison opened this issue Aug 13, 2020 · 1 comment · Fixed by #24340
Closed

Adopting aws_default_security_group does not update tags #14631

gdavison opened this issue Aug 13, 2020 · 1 comment · Fixed by #24340
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.

Comments

@gdavison
Copy link
Contributor

The aws_default_security_group resource clears all rules when "adopting" the security group and updates with the rules specified in the Terraform configuration. It does not do the same with tags.

In EC2 Classic, if the existing default security group has tags set that do not match the tags set in the Terraform configuration, this results in a non-empty plan.

This likely also occurs in VPC, but the tags will have to be created out-of-band for testing.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Affected Resource(s)

  • aws_default_security_group
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Aug 13, 2020
@DrFaust92 DrFaust92 mentioned this issue Aug 20, 2020
Closed
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Jul 20, 2022
ewbankkit added a commit that referenced this issue Jul 20, 2022
@ewbankkit
r/aws_default_security_group: Tidy up 'TestAccVPCDefaultSecurityGroup…
b9add85 
…_Classic_empty'. Fixes #14631.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCDefaultSecurityGroup_Classic_empty' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCDefaultSecurityGroup_Classic_empty -timeout 180m
=== RUN   TestAccVPCDefaultSecurityGroup_Classic_empty
=== PAUSE TestAccVPCDefaultSecurityGroup_Classic_empty
=== CONT  TestAccVPCDefaultSecurityGroup_Classic_empty
--- PASS: TestAccVPCDefaultSecurityGroup_Classic_empty (11.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	15.310s
@ewbankkit ewbankkit mentioned this issue Jul 21, 2022
Merged
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Milestone
No milestone
2 participants
@gdavison @ewbankkit