Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags for security group are not working #470

Closed
sagar-jani opened this issue Jul 23, 2020 · 10 comments
Closed

Tags for security group are not working #470

sagar-jani opened this issue Jul 23, 2020 · 10 comments

Comments

@sagar-jani
Copy link

I have a default security group configured as :

data "aws_security_group" "security_group" {
  name   = "default"
  vpc_id = module.home-protec-vpc.vpc_id
}

And tags are configured as :

default_security_group_tags = {
   AppName = "TestSG"
 }

But the tags are not created, is there something missing ?

@DrFaust92
Copy link
Contributor

hey @sagar-jani, what version of the aws provider are you using?

@c0ntax
Copy link

c0ntax commented Aug 6, 2020

@DrFaust92 I have this issue as well. My aws provider is 2.70.0 and this module's version is 2.44.0. I believe that this was also a bug for previous versions of both the provider and module.

@c0ntax
Copy link

c0ntax commented Aug 6, 2020

Possibly related, but assigning default_security_group_name also seems to have no effect

@c0ntax
Copy link

c0ntax commented Aug 6, 2020

Oops. Put this one down to user error on my part. I hadn't set manage_default_security_group to true. Ignore me. I shall go away now. ;-)

@sagar-jani
Copy link
Author

Thanks @c0ntax , I have tried setting it to manage_default_security_group. But it gives me below error :

Error: Invalid dynamic for_each value

  on .terraform/modules/home-protec-vpc/terraform-aws-vpc-2.44.0/main.tf line 77, in resource "aws_default_security_group" "this":
  77:     for_each = var.default_security_group_egress
    |----------------
    | var.default_security_group_egress is null

Cannot use a null value in for_each.

Releasing state lock. This may take a few moments..

@DrFaust92
Copy link
Contributor

@DrFaust92
Copy link
Contributor

@trallnag
Copy link

I think such dependencies should be pointed out in the variables documentation

@bryantbiggs
Copy link
Member

hi @trallnag - what dependencies should be called out?

closing this out for now as this appears to be an upstream issue with the AWS provider

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants