Merge pull request #30681 from hashicorp/f-aws_quicksight_namespace

New Resource: `aws_quicksight_namespace`
hashicorp · Apr 12, 2023 · 355f6cb · 355f6cb
2 parents fbd2c54 + e7fcead
commit 355f6cb
Show file tree

Hide file tree

Showing 14 changed files with 649 additions and 10 deletions.
diff --git a/.changelog/30681.txt b/.changelog/30681.txt
@@ -0,0 +1,3 @@
+```release-note:new-resource
+aws_quicksight_namespace
+```
diff --git a/internal/provider/fwprovider/intercept.go b/internal/provider/fwprovider/intercept.go
@@ -377,7 +377,7 @@ func (r tagsInterceptor) read(ctx context.Context, request resource.ReadRequest,
 			if identifierAttribute := r.tags.IdentifierAttribute; identifierAttribute != "" {
 				var identifier string
 
-				diags.Append(request.State.GetAttribute(ctx, path.Root(identifierAttribute), &identifier)...)
+				diags.Append(response.State.GetAttribute(ctx, path.Root(identifierAttribute), &identifier)...)
 
 				if diags.HasError() {
 					return ctx, diags

diff --git a/internal/service/quicksight/account_subscription.go b/internal/service/quicksight/account_subscription.go
@@ -22,7 +22,7 @@ import (
 )
 
 // Function annotations are used for resource registration to the Provider. DO NOT EDIT.
-// @SDKResource("aws_quicksight_account_subscription")
+// @SDKResource("aws_quicksight_account_subscription", name="Account Subscription")
 func ResourceAccountSubscription() *schema.Resource {
 	return &schema.Resource{
 		CreateWithoutTimeout: resourceAccountSubscriptionCreate,

diff --git a/internal/service/quicksight/data_set_data_source.go b/internal/service/quicksight/data_set_data_source.go
@@ -14,7 +14,7 @@ import (
 	"github.com/hashicorp/terraform-provider-aws/names"
 )
 
-// @SDKDataSource("aws_quicksight_data_set")
+// @SDKDataSource("aws_quicksight_data_set", name="Data Set")
 func DataSourceDataSet() *schema.Resource {
 	return &schema.Resource{
 		ReadWithoutTimeout: dataSourceDataSetRead,

diff --git a/internal/service/quicksight/exports_test.go b/internal/service/quicksight/exports_test.go
@@ -2,6 +2,7 @@ package quicksight
 
 // Exports for use in tests only.
 var (
-	ResourceIngestion           = newResourceIngestion
 	ResourceIAMPolicyAssignment = newResourceIAMPolicyAssignment
+	ResourceIngestion           = newResourceIngestion
+	ResourceNamespace           = newResourceNamespace
 )
diff --git a/internal/service/quicksight/group.go b/internal/service/quicksight/group.go
@@ -16,7 +16,7 @@ import (
 	"github.com/hashicorp/terraform-provider-aws/internal/errs/sdkdiag"
 )
 
-// @SDKResource("aws_quicksight_group")
+// @SDKResource("aws_quicksight_group", name="Group")
 func ResourceGroup() *schema.Resource {
 	return &schema.Resource{
 		CreateWithoutTimeout: resourceGroupCreate,

diff --git a/internal/service/quicksight/group_membership.go b/internal/service/quicksight/group_membership.go
@@ -15,7 +15,7 @@ import (
 	"github.com/hashicorp/terraform-provider-aws/internal/conns"
 )
 
-// @SDKResource("aws_quicksight_group_membership")
+// @SDKResource("aws_quicksight_group_membership", name="Group Membership")
 func ResourceGroupMembership() *schema.Resource {
 	return &schema.Resource{
 		CreateWithoutTimeout: resourceGroupMembershipCreate,

diff --git a/internal/service/quicksight/iam_policy_assignment.go b/internal/service/quicksight/iam_policy_assignment.go
@@ -30,13 +30,13 @@ import (
 	"github.com/hashicorp/terraform-provider-aws/names"
 )
 
-// @FrameworkResource
+// @FrameworkResource(name="IAM Policy Assignment")
 func newResourceIAMPolicyAssignment(_ context.Context) (resource.ResourceWithConfigure, error) {
 	return &resourceIAMPolicyAssignment{}, nil
 }
 
 const (
-	ResNameIAMPolicyAssignment = "IAMPolicyAssignment"
+	ResNameIAMPolicyAssignment = "IAM Policy Assignment"
 
 	DefaultIAMPolicyAssignmentNamespace = "default"
 	iamPropagationTimeout               = 2 * time.Minute

diff --git a/internal/service/quicksight/ingestion.go b/internal/service/quicksight/ingestion.go
@@ -25,7 +25,7 @@ import (
 	"github.com/hashicorp/terraform-provider-aws/names"
 )
 
-// @FrameworkResource
+// @FrameworkResource(name="Ingestion")
 func newResourceIngestion(_ context.Context) (resource.ResourceWithConfigure, error) {
 	return &resourceIngestion{}, nil
 }