Skip to content

Commit

Permalink
Merge pull request #30666 from amacf/f-docdbelastic-service-creation
Browse files Browse the repository at this point in the history
New Service: Document DB Elastic
  • Loading branch information
ewbankkit authored Apr 12, 2023
2 parents 1b7c93a + a7f2eaa commit fbd2c54
Show file tree
Hide file tree
Showing 18 changed files with 203 additions and 73 deletions.
102 changes: 58 additions & 44 deletions .ci/.semgrep-service-name1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1015,6 +1015,64 @@ rules:
patterns:
- pattern-regex: "(?i)DocDB"
severity: WARNING
- id: docdbelastic-in-func-name
languages:
- go
message: Do not use "DocDBElastic" in func name inside docdbelastic package
paths:
include:
- internal/service/docdbelastic
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)DocDBElastic"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: docdbelastic-in-test-name
languages:
- go
message: Include "DocDBElastic" in test name
paths:
include:
- internal/service/docdbelastic/*_test.go
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccDocDBElastic"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: docdbelastic-in-const-name
languages:
- go
message: Do not use "DocDBElastic" in const name inside docdbelastic package
paths:
include:
- internal/service/docdbelastic
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)DocDBElastic"
severity: WARNING
- id: docdbelastic-in-var-name
languages:
- go
message: Do not use "DocDBElastic" in var name inside docdbelastic package
paths:
include:
- internal/service/docdbelastic
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)DocDBElastic"
severity: WARNING
- id: ds-in-func-name
languages:
- go
Expand Down Expand Up @@ -3291,47 +3349,3 @@ rules:
patterns:
- pattern-regex: "(?i)inspectorv2"
severity: WARNING
- id: inspectorv2-in-var-name
languages:
- go
message: Do not use "inspectorv2" in var name inside inspector2 package
paths:
include:
- internal/service/inspector2
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)inspectorv2"
severity: WARNING
- id: iot-in-func-name
languages:
- go
message: Do not use "IoT" in func name inside iot package
paths:
include:
- internal/service/iot
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)IoT"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: iot-in-test-name
languages:
- go
message: Include "IoT" in test name
paths:
include:
- internal/service/iot/*_test.go
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccIoT"
- pattern-regex: ^TestAcc.*
severity: WARNING
73 changes: 44 additions & 29 deletions .ci/.semgrep-service-name2.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,49 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: inspectorv2-in-var-name
languages:
- go
message: Do not use "inspectorv2" in var name inside inspector2 package
paths:
include:
- internal/service/inspector2
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)inspectorv2"
severity: WARNING
- id: iot-in-func-name
languages:
- go
message: Do not use "IoT" in func name inside iot package
paths:
include:
- internal/service/iot
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)IoT"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: iot-in-test-name
languages:
- go
message: Include "IoT" in test name
paths:
include:
- internal/service/iot/*_test.go
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccIoT"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: iot-in-const-name
languages:
- go
Expand Down Expand Up @@ -3305,32 +3349,3 @@ rules:
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
- id: redshift-in-var-name
languages:
- go
message: Do not use "Redshift" in var name inside redshift package
paths:
include:
- internal/service/redshift
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
- id: redshiftdata-in-func-name
languages:
- go
message: Do not use "RedshiftData" in func name inside redshiftdata package
paths:
include:
- internal/service/redshiftdata
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)RedshiftData"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
29 changes: 29 additions & 0 deletions .ci/.semgrep-service-name3.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,34 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: redshift-in-var-name
languages:
- go
message: Do not use "Redshift" in var name inside redshift package
paths:
include:
- internal/service/redshift
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
- id: redshiftdata-in-func-name
languages:
- go
message: Do not use "RedshiftData" in func name inside redshiftdata package
paths:
include:
- internal/service/redshiftdata
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)RedshiftData"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: redshiftdata-in-test-name
languages:
- go
Expand Down
2 changes: 2 additions & 0 deletions .github/labeler-issue-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,8 @@ service/dms:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_dms_'
service/docdb:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_docdb_'
service/docdbelastic:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_docdbelastic_'
service/drs:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_drs_'
service/ds:
Expand Down
3 changes: 3 additions & 0 deletions .github/labeler-pr-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,9 @@ service/dms:
service/docdb:
- 'internal/service/docdb/**/*'
- 'website/**/docdb_*'
service/docdbelastic:
- 'internal/service/docdbelastic/**/*'
- 'website/**/docdbelastic_*'
service/drs:
- 'internal/service/drs/**/*'
- 'website/**/drs_*'
Expand Down
1 change: 1 addition & 0 deletions .teamcity/components/generated/services_all.kt
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ val services = mapOf(
"dlm" to ServiceSpec("DLM (Data Lifecycle Manager)"),
"dms" to ServiceSpec("DMS (Database Migration)", vpcLock = true),
"docdb" to ServiceSpec("DocDB (DocumentDB)", vpcLock = true),
"docdbelastic" to ServiceSpec("DocDB (DocumentDB) Elastic"),
"ds" to ServiceSpec("Directory Service", vpcLock = true),
"dynamodb" to ServiceSpec("DynamoDB"),
"ec2" to ServiceSpec("EC2 (Elastic Compute Cloud)", vpcLock = true),
Expand Down
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ require (
github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.20.9
github.com/aws/aws-sdk-go-v2/service/comprehend v1.23.2
github.com/aws/aws-sdk-go-v2/service/computeoptimizer v1.22.2
github.com/aws/aws-sdk-go-v2/service/docdbelastic v1.1.8
github.com/aws/aws-sdk-go-v2/service/ec2 v1.93.2
github.com/aws/aws-sdk-go-v2/service/fis v1.14.8
github.com/aws/aws-sdk-go-v2/service/healthlake v1.15.9
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ github.com/aws/aws-sdk-go-v2/service/comprehend v1.23.2 h1:fik7j3E3LcSmDM8CUcQI3
github.com/aws/aws-sdk-go-v2/service/comprehend v1.23.2/go.mod h1:wosyuBOnz9m1Oj9F3wuCDRwomUxebSVCNc+PeQCQ5DE=
github.com/aws/aws-sdk-go-v2/service/computeoptimizer v1.22.2 h1:wgJr0EwZea2E7Xv8nawVIUrf7eam/dLaxHBxC4jbkos=
github.com/aws/aws-sdk-go-v2/service/computeoptimizer v1.22.2/go.mod h1:d0fe6UNPcZ3FMT7NFdIuKrF4SNXPWDhxSzA8N/z+KP4=
github.com/aws/aws-sdk-go-v2/service/docdbelastic v1.1.8 h1:Tap169lBqVla3crC6+2l7lkU2XZoZzBa4LnbSdqtWH4=
github.com/aws/aws-sdk-go-v2/service/docdbelastic v1.1.8/go.mod h1:nQzuGMnFeUNmJshfky2ZF+QSuojEyVIwvxnBjVOYOg0=
github.com/aws/aws-sdk-go-v2/service/ec2 v1.93.2 h1:c6a19AjfhEXKlEX63cnlWtSQ4nzENihHZOG0I3wH6BE=
github.com/aws/aws-sdk-go-v2/service/ec2 v1.93.2/go.mod h1:VX22JN3HQXDtQ3uS4h4TtM+K11vydq58tpHTlsm8TL8=
github.com/aws/aws-sdk-go-v2/service/fis v1.14.8 h1:P02MaOm7ef9TlAB5n1AgPdYVZ7L7m7c96BuTe14qbgM=
Expand Down
1 change: 1 addition & 0 deletions infrastructure/repository/labels-service.tf
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ variable "service_labels" {
"dlm",
"dms",
"docdb",
"docdbelastic",
"drs",
"ds",
"dynamodb",
Expand Down
6 changes: 6 additions & 0 deletions internal/conns/awsclient_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions internal/conns/config_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/provider/service_packages_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions internal/service/docdbelastic/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Terraform AWS Provider DocDB Elastic Package

This area is primarily for AWS provider contributors and maintainers. For information on _using_ Terraform and the AWS provider, see the links below.

## Handy Links

* [Find out about contributing](https://hashicorp.github.io/terraform-provider-aws/#contribute) to the AWS provider!
* AWS Provider Docs: [Home](https://registry.terraform.io/providers/hashicorp/aws/latest/docs)
* AWS Provider Docs: [One of the DocDB resources](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/docdb_cluster)
* AWS Docs: [AWS SDK for Go DocDB](https://docs.aws.amazon.com/sdk-for-go/api/service/docdb/)
34 changes: 34 additions & 0 deletions internal/service/docdbelastic/service_package_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions names/consts_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit fbd2c54

Please sign in to comment.