Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Update Go Module to Go 1.20 and remove go-multierror direct dependency #181

Merged
merged 2 commits into from
Sep 6, 2023
Merged

all: Update Go Module to Go 1.20 and remove go-multierror direct dependency #181

merged 2 commits into from
Sep 6, 2023

Commits on Sep 6, 2023

  1. all: Update Go Module to Go 1.20 and remove go-multierror direct depe… 

    …ndency

Reference: https://pkg.go.dev/errors#Join
Reference: https://pkg.go.dev/math/rand#Seed
Reference: #99
Reference: #180

Previously from `golangci-lint` after Go 1.20 upgrade:

```
helper/acctest/random.go:24:2: SA1019: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (staticcheck)
        rand.Seed(time.Now().UTC().UnixNano())
        ^
```

Fully removing the go-multierror dependency will require some other upstream updates, e.g.

```
# github.com/hashicorp/go-multierror
github.com/hashicorp/terraform-plugin-testing/helper/resource
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema
github.com/hashicorp/go-multierror
```
    @bflad
    bflad committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e7b3ad6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into bflad/go120upgrade

    @bflad
    bflad authored Sep 6, 2023
    Configuration menu
    Copy the full SHA
    1f80941 View commit details
    Browse the repository at this point in the history