all: Update Go Module to Go 1.20 and remove go-multierror direct dependency #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndency Reference: https://pkg.go.dev/errors#Join Reference: https://pkg.go.dev/math/rand#Seed Reference: #99 Reference: #180 Previously from `golangci-lint` after Go 1.20 upgrade: ``` helper/acctest/random.go:24:2: SA1019: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (staticcheck) rand.Seed(time.Now().UTC().UnixNano()) ^ ``` Fully removing the go-multierror dependency will require some other upstream updates, e.g. ``` # github.com/hashicorp/go-multierror github.com/hashicorp/terraform-plugin-testing/helper/resource github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema github.com/hashicorp/go-multierror ```
bflad
added
enhancement
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://pkg.go.dev/errors#Join
Reference: https://pkg.go.dev/math/rand#Seed
Closes #99
Closes #180
Previously from
golangci-lintafter Go 1.20 upgrade:Fully removing the go-multierror dependency will require some other upstream updates, e.g.