Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly parsing request body when http.NoBody is used #168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tjasko
Copy link

@tjasko tjasko commented Jun 23, 2022

This fix corrects a behavior when http.NoBody is used as the request body, as currently, the retryablehttp.getBodyReaderAndContentLength() function will return a ReaderFunc that when called returns an io.Reader, that will output a literal "0" string on the wire as the HTTP request body.

As such, a fix & test has been implemented to no-op when http.NoBody is used.

This issue was found as I was testing this library when a POST request was being done with no request body.

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 23, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants