-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rate-limit konnect requests when receiving 429s #705
Conversation
0ef7ffe
to
6f96f8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please get a +1 from @tjasko.
88b4081
to
2eecede
Compare
Codecov Report
@@ Coverage Diff @@
## main #705 +/- ##
==========================================
- Coverage 43.50% 43.28% -0.23%
==========================================
Files 74 74
Lines 8923 8969 +46
==========================================
Hits 3882 3882
- Misses 4671 4717 +46
Partials 370 370
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem sane, however, aren't we waiting on hashicorp/go-retryablehttp#168 to get merged?
That's not a blocker, because the way decK uses the underlying library via |
b5c967a
to
0eb2151
Compare
No description provided.