Remove extraneous headers and nav item from versioned docs #2692
+149
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
im2nguyen
requested review from
a team,
rmainwork and
LeahMarieBush
and removed request for
a team
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
RubenSandwich
requested changes
Feb 21, 2025
There was a problem hiding this comment.
@im2nguyen because this change is a quite big one, we should write some tests.
You can see an example of testing remote-content's loadStaticProps function here:
(Also we didn't write any tests in it for latest. 😢
RubenSandwich
approved these changes
Feb 21, 2025
|
Thanks @RubenSandwich! I updated with testing instructions so folks in the future can test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Relevant links
🗒️ What
🤷 Why
🛠️ How
📸 Design Screenshots
🧪 Testing
UI
Go to a versioned doc in the deploy preview.
Select a different version and verify the sidebar navigation is the same. In previous versions, there would be an extraneous header.
Previous version (extra "Framework" and "Overview")
Alternatively, run the test suite.
npm testand confirm all the tests pass.💭 Anything else?