-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only async trigger changes #8778
Closed
Closed
Commits on Sep 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ef66dd0 - Browse repository at this point
Copy the full SHA ef66dd0View commit details -
Sync node info when updating sync state
Previously we had a variable that would track whether the node's information was in sync with the servers. This was a shared variable in the local state which required locking to read/write. Rather than guarding access to this variable we now sync node updates when we see that the node info is out of sync. This only happens in one location: updateSyncState(). Additionally, rather than SkippingNodeUpdate based on the shared variable we now let the servers determine whether the node update should be skipped. This is checked in structs.RegisterRequest.ChangesNode().
Configuration menu - View commit details
-
Copy full SHA for 704ddee - Browse repository at this point
Copy the full SHA 704ddeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84560ab - Browse repository at this point
Copy the full SHA 84560abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a1f586 - Browse repository at this point
Copy the full SHA 0a1f586View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac177c6 - Browse repository at this point
Copy the full SHA ac177c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a970ebd - Browse repository at this point
Copy the full SHA a970ebdView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb6b8cc - Browse repository at this point
Copy the full SHA eb6b8ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7e3d4c - Browse repository at this point
Copy the full SHA b7e3d4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 770139f - Browse repository at this point
Copy the full SHA 770139fView commit details
Commits on Oct 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f6d637f - Browse repository at this point
Copy the full SHA f6d637fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.