Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only async trigger changes #8778

Closed
wants to merge 10 commits into from
Closed

only async trigger changes #8778

wants to merge 10 commits into from

Commits on Sep 30, 2020

  1. Make agent<->server sync asynchronous in agent endpoints

    @freddygv @hanshasselberg
    freddygv authored and hanshasselberg committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    ef66dd0 View commit details
    Browse the repository at this point in the history

  2. Sync node info when updating sync state 

    Previously we had a variable that would track whether the node's
information was in sync with the servers.

This was a shared variable in the local state which required locking to
read/write.

Rather than guarding access to this variable we now sync node updates
when we see that the node info is out of sync. This only happens in one
location: updateSyncState().

Additionally, rather than SkippingNodeUpdate based on the shared
variable we now let the servers determine whether the node update should
be skipped. This is checked in structs.RegisterRequest.ChangesNode().
    @freddygv @hanshasselberg
    freddygv authored and hanshasselberg committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    704ddee View commit details
    Browse the repository at this point in the history

  3. adding WaitForService to fix tests

    @hanshasselberg
    hanshasselberg committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    84560ab View commit details
    Browse the repository at this point in the history

  4. remove debug out

    @hanshasselberg
    hanshasselberg committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    0a1f586 View commit details
    Browse the repository at this point in the history

  5. fix potential panic

    @hanshasselberg
    hanshasselberg committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    ac177c6 View commit details
    Browse the repository at this point in the history

  6. wait for service to be synced

    @hanshasselberg
    hanshasselberg committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    a970ebd View commit details
    Browse the repository at this point in the history

  7. t->r

    @hanshasselberg
    hanshasselberg committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    eb6b8cc View commit details
    Browse the repository at this point in the history

  8. remove accidental code

    @hanshasselberg
    hanshasselberg committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    b7e3d4c View commit details
    Browse the repository at this point in the history

  9. fix TestServer_Leave by increasing timeout

    @hanshasselberg
    hanshasselberg committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    770139f View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. return and handle syncNodeInfo error

    @hanshasselberg
    hanshasselberg committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    f6d637f View commit details
    Browse the repository at this point in the history