only async trigger changes #8778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had a variable that would track whether the node's information was in sync with the servers. This was a shared variable in the local state which required locking to read/write. Rather than guarding access to this variable we now sync node updates when we see that the node info is out of sync. This only happens in one location: updateSyncState(). Additionally, rather than SkippingNodeUpdate based on the shared variable we now let the servers determine whether the node update should be skipped. This is checked in structs.RegisterRequest.ChangesNode().
hanshasselberg
force-pushed
the
only_async_trigger_changes
branch
from
c10e88c
to
ac177c6
Compare
hanshasselberg
commented
Sep 30, 2020
| @@ -212,6 +212,16 @@ func TestAPI_HealthChecks(t *testing.T) { | |||
| t.Fatalf("err: %v", err) | |||
| } | |||
|
|
|||
| retry.Run(t, func(r *retry.R) { | |||
There was a problem hiding this comment.
Wait for service to sync to catalog. testrpc cannot be imported here.
hanshasselberg
commented
Sep 30, 2020
| @@ -64,6 +64,7 @@ func WaitUntilNoLeader(t *testing.T, rpc rpcFn, dc string, options ...waitOption | |||
| type waitOption struct { | |||
| Token string | |||
| WaitForAntiEntropySync bool | |||
| WaitForService string | |||
There was a problem hiding this comment.
Add ability to wait for a service because services are no longer synced immediately.
hanshasselberg
commented
Sep 30, 2020
| @@ -250,7 +250,6 @@ func NewTestServerConfigT(t TestingTB, cb ServerConfigCallback) (*TestServer, er | |||
| return nil, errors.Wrap(err, "failed marshaling json") | |||
| } | |||
|
|
|||
| t.Logf("CONFIG JSON: %s", string(b)) | |||
hanshasselberg
commented
Sep 30, 2020
| // Should lose a peer | ||
| retry.Run(t, func(r *retry.R) { | ||
| timer := &retry.Timer{Timeout: 10 * time.Second, Wait: 500 * time.Millisecond} | ||
| retry.RunWith(timer, t, func(r *retry.R) { |
There was a problem hiding this comment.
hopefully fixing a flaky test with this.
dnephin
reviewed
Sep 30, 2020
agent/local/state.go
Outdated
Comment on lines
1355
to
1359
| return nil | ||
|
|
||
| default: | ||
| l.logger.Warn("Syncing node info failed.", "error", err) | ||
| return err |
There was a problem hiding this comment.
What are the consequences of this function no longer returning an error?
There was a problem hiding this comment.
Based on your comment I revisited this part and reverted to returning and handling any errors from syncNodeInfo. I also added a longer explanation for these changes to the PR description.
|
|
|
Closing as this is over two years old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny step towards fixing #6616.
This PR stops all agent endpoints from syncing the changes synchronously and leaves it to the asynchronous ticker to pick up these changes. And makes changes to how
syncNodeInfois called...The evolution of
syncNodeInfo:original:
updateSyncState-- among other things -- determines if node needs syncing and setnodeInfoInSyncSyncChangesadds node info to every service/check update if!nodeInfoInSyncand has a manualsyncNodeInfocall in case everything before failed to updated nodeinfoafter #7189:
updateSyncStatedetermines if node needs syncing and setnodeInfoInSyncSyncChangescallssyncNodeInfoupfront instead of appending nodeinfo to every service/check updateproposed:
updateSyncStatedetermines if node needs syncing and callssyncNodeInforight awaySyncChangesdoesn't try to sync node infoThis PR potentially makes the tests more flaky because services/checks are no longer synced immediately.