Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Specify port in host for ingress example #8167

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

crhino
Copy link
Contributor

@crhino crhino commented Jun 22, 2020

This example shows a TLS enabled ingress config on a non-https port.
Currently, that means we require the port to be specified in one of the
host entries to route traffic.

Pulled from #8062 (comment).

This example shows a TLS enabled ingress config on a non-https port.
Currently, that means we require the port to be specified in one of the
host entries to route traffic.
@crhino crhino added type/docs Documentation needs to be created/updated/clarified type/docs-cherrypick labels Jun 22, 2020
@crhino crhino requested a review from a team June 22, 2020 19:27
@crhino
Copy link
Contributor Author

crhino commented Jun 22, 2020

@nicholasjackson Added this to the example from your comment!

@crhino crhino changed the title docs: Specify port in host for example docs: Specify port in host for ingress example Jun 22, 2020
Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crhino crhino merged commit 2904cda into master Jun 23, 2020
@crhino crhino deleted the docs/update-ingress-example branch June 23, 2020 19:41
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 2904cda onto stable-website succeeded!

hashicorp-ci pushed a commit that referenced this pull request Jun 23, 2020
This example shows a TLS enabled ingress config on a non-https port.
Currently, that means we require the port to be specified in one of the
host entries to route traffic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants