-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates docs with ingress Host header changes #8062
Conversation
Clarify that a Host header is required for L7 protocols, and specify that the default is to use the Consul DNS ingress subdomain
17e2a56
to
aa2b467
Compare
@crhino In running and using an Ingress Gateway section, could we also include that layer7 routing can be used to direct traffic from Ingress Gateway to services? This would be optional but would complete the Ingress Gateway flow in my opinion. |
@david-yu Pushed a change to add a sentence like that, let me know how you feel? |
Added a note in the config entry page about port numbers from feedback in #8045 |
Ok this LGTM, thanks! |
🍒✅ Cherry pick of commit bb103f2 onto |
* Updates docs with ingress Host header changes Clarify that a Host header is required for L7 protocols, and specify that the default is to use the Consul DNS ingress subdomain * Add sentence about using '*' by itself for testing * Add optional step for using L7 routing config * Note that port numbers may need to be added in the Hosts field
@crhino Bit late on this one since it has already been merged but I suggest the example is updated to reflect the documentation enhancement. If folks cut and paste the sample it will cause confusion when it does not work. Either the below example should have the port changed to {
Port = 4567
Protocol = "http"
Services = [
{
Name = "api"
Hosts = ["foo.example.com"]
},
{
Name = "web"
Hosts = ["website.example.com"]
}
]
} |
Hmm is it just me @crhino or did the docs not get cherry picked here? https://www.consul.io/docs/connect/ingress-gateway |
@david-yu These changes are in the config entry documentation: https://www.consul.io/docs/agent/config-entries/ingress-gateway |
Clarify that a Host header is required for L7 protocols, and specify
that the default is to use the Consul DNS ingress subdomain
This comes from merging #7990 and #8083, as well as just better clarity.