Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for consul sidecar annotations #12162

Closed
wants to merge 2 commits into from
Closed

Add docs for consul sidecar annotations #12162

wants to merge 2 commits into from

Conversation

ndhanushkodi
Copy link
Contributor

@ndhanushkodi ndhanushkodi commented Jan 22, 2022 •
edited
Loading

From community PR: hashicorp/consul-k8s#956

@ndhanushkodi ndhanushkodi requested a review from a team as a code owner January 22, 2022 00:27
@ndhanushkodi ndhanushkodi added type/docs Documentation needs to be created/updated/clarified type/docs-cherrypick labels Jan 22, 2022
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@ndhanushkodi ndhanushkodi changed the title add docs for annotations Add docs for consul sidecar annotations Jan 22, 2022
@ndhanushkodi ndhanushkodi added the pr/no-changelog PR does not need a corresponding .changelog entry label Jan 22, 2022
@ndhanushkodi ndhanushkodi requested review from a team, thisisnotashwin and t-eckert and removed request for a team January 22, 2022 00:29
@david-yu
Copy link
Contributor

Looks like these changes were already merged somehow in main. I'l go ahead and close.

@david-yu david-yu closed this Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-yu david-yu david-yu approved these changes

@t-eckert t-eckert t-eckert approved these changes

@thisisnotashwin thisisnotashwin Awaiting requested review from thisisnotashwin

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndhanushkodi @hashicorp-ci @david-yu @t-eckert