control-plane: Add possibility to manage consul sidecar resources with annotations #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h annotations - default resources are set via flags of the injector - can be overriden with annotations on pods
|
Thanks for the PR @rrondeau this sounds very useful. I'm curious how is it that your pod emits 150k metrics? That is definitely something that we did not consider before! |
|
Yeah we have 2 types of pod that need more than 50Mi of memory.
$ curl -s 127.0.0.1:20200/metrics | grep ^envoy_ | wc -l
11461
/ $ curl -s 127.0.0.1:20200/metrics | grep -v -e ^envoy_ -e ^# -e ^$ | wc -l
138533 |
ishustava
requested review from
a team,
ndhanushkodi and
t-eckert
and removed request for
a team and
t-eckert
ndhanushkodi
added a commit
that referenced
this pull request
Jan 19, 2022
2 tasks
ndhanushkodi
added a commit
that referenced
this pull request
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
We are currently migrating our metrics polling to use merged metrics and we have one issue.
Some of our pods return lots of metrics (~150k) and the consul sidecar get OOM killed.
We bump the memory of the sidecar but dont want to waste memory where we dont need it.
Changes proposed in this PR:
I renamed the injector flags to mirror the envoy sidecar configuration.
The code is heavily inspired by envoy sidecar configuration but i kept the
consulSidecarResourcesobject in the subcommand.If you want that i replicate the envoy stuff and split the resources into 4 vars when passing the settings to the handler, i can do it.
I am open to any ideas / modifications :)
How I've tested this PR:
How I expect reviewers to test this PR:
¯\(ツ)/¯
Checklist: