Remove custom balancer, use default pick_first #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisunji
changed the title
This was referenced Jan 18, 2023
mikemorris
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
LGTM with minor tweaks, tested by updating this dependency in Consul API Gateway over in hashicorp/consul-api-gateway#484 and our unit tests are passing and no longer flaky!
pglass
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some deep code dives we concluded that calling
UpdateStateon theClientConnof a resolver is a sufficient cut-off point for considering the address of the connection updated. This means there is no more need for a custom balancer to track sub-connections and we can simplify the watcher implementation greatly.Since we are passing at most one address at a time, the default
pick_firstbalancer is sufficient for our needs.