This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
deps: update consul-server-connection-manager #484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves test flakiness issues caused by the un-threadsafety of registering a gRPC balancer in
NewWatcher
rather than aninit()
function. This didn't cause problems in actual deployments, but could happen when in our test suite when multiple calls toNewWatcher
happened concurrently.Changes proposed in this PR:
pick_first
balancer.globalWatcherMutex
(added in Integrate consul-server-connection-manager library #449)client.WatchServers
method which was responsible for a race condition occurring infrequently on timeouts, particularly from the discovery-error unit test.consul-api-gateway/internal/commands/exec/exec.go
Line 85 in 874f324
How I've tested this PR:
Research and discussion on upstream implementation with @kisunji and @pglass, testing hashicorp/consul-server-connection-manager#28 as a dependency locally and in CI. Thanks for the help in tracking down these issues!
How I expect reviewers to test this PR:
The CI unit tests should stop being flaky.
Checklist:
Tests addedCHANGELOG entry added