Fix logic for enabling ui metrics #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
requested review from
a team,
kschoche and
t-eckert
and removed request for
a team
t-eckert
approved these changes
Nov 8, 2021
Previously ui metrics would be enabled when
`global.metrics.enabled=false` and `ui.metrics.enabled=-`. Now that
would cause UI metrics to be disabled which makes sense since "-" means
inherit from `global.metrics.enabled`.
The logic is now to enable ui metrics when:
```
ui.enabled &&
(
(global.metrics.enabled == true && ui.metrics.enabled == "-") ||
(ui.metrics.enabled == true)
)
```
lkysow
force-pushed
the
lkysow/ui-metrics-enabled
branch
from
2b0036f
to
92f683f
Compare
rrondeau
pushed a commit
to rrondeau/consul-k8s
that referenced
this pull request
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously ui metrics would be enabled when
global.metrics.enabled=falseandui.metrics.enabled=-. Now thatwould cause UI metrics to be disabled which makes sense since "-" means
inherit from
global.metrics.enabled.The logic is now to enable ui metrics when:
Fixes #642
Checklist: