Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm:UI metrics enabled when global.metrics.enabled=false #642

Closed
lkysow opened this issue Jul 11, 2021 · 0 comments · Fixed by #841
Closed

helm:UI metrics enabled when global.metrics.enabled=false #642

lkysow opened this issue Jul 11, 2021 · 0 comments · Fixed by #841

Comments

@lkysow
Copy link
Member

lkysow commented Jul 11, 2021

helm template consul hashicorp/consul --version 0.32.0 -s templates/server-config-configmap.yaml
---
# Source: consul/templates/server-config-configmap.yaml
# StatefulSet to run the actual Consul server cluster.
apiVersion: v1
kind: ConfigMap
metadata:
  name: consul-consul-server-config
  namespace: default
  labels:
    app: consul
    chart: consul-helm
    heritage: Helm
    release: consul
data:
  extra-from-values.json: |-
    {}

  ui-config.json: |-
    {
      "ui_config": {
        "enabled": true,
        "metrics_provider": "prometheus",
        "metrics_proxy": {
          "base_url": "http://prometheus-server"
        }
      }
    }
  central-config.json: |-
    {
      "enable_central_service_config": true
    }

The default of global.metrics.enabled is false and the default of ui.metrics.enabled is - so I'd expect the metrics to default to false.

I think what's happening is that - is being type-converted to boolean true in:

https://github.com/hashicorp/consul-helm/blob/9598a357b19184a73309077a536fefab629e41e1/templates/server-config-configmap.yaml#L30

@t-eckert t-eckert changed the title UI metrics enabled when global.metrics.enabled=false helm:UI metrics enabled when global.metrics.enabled=false Aug 24, 2021
@t-eckert t-eckert transferred this issue from hashicorp/consul-helm Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants