Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't support syncing multiple addresses when k8s service has multiple ports #511

Merged
merged 3 commits into from
May 4, 2021
Merged

Don't support syncing multiple addresses when k8s service has multiple ports #511

merged 3 commits into from
May 4, 2021

Commits on May 4, 2021

  1. Don't support syncing multiple addresses when k8s service has multipl… 

    …e ports.

Previously, we set a tagged address for each Kubernetes service port,
using the "virtual-" prefix for the tagged address key. For example,
if a service port is named "tcp", then we synced it to Consul with
the tagged address key "virtual-tcp".

However, since Consul doesn't really support multiple ports on a service yet,
this is unnecessary. So instead, we will find the service's target port
that is equal to the service port we are registering with Consul
and use that as the Port for the tagged address. Otherwise,
if we can't find the target port, we will set the tagged address's port to 0
(it will still have the cluster IP set).
    @ishustava
    ishustava committed May 4, 2021
    Configuration menu
    Copy the full SHA
    807207b View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @ishustava
    ishustava committed May 4, 2021
    Configuration menu
    Copy the full SHA
    71fbb16 View commit details
    Browse the repository at this point in the history

  3. code review updates

    @ishustava
    ishustava committed May 4, 2021
    Configuration menu
    Copy the full SHA
    14e1e8c View commit details
    Browse the repository at this point in the history