Don't support syncing multiple addresses when k8s service has multiple ports #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ports. Previously, we set a tagged address for each Kubernetes service port, using the "virtual-" prefix for the tagged address key. For example, if a service port is named "tcp", then we synced it to Consul with the tagged address key "virtual-tcp". However, since Consul doesn't really support multiple ports on a service yet, this is unnecessary. So instead, we will find the service's target port that is equal to the service port we are registering with Consul and use that as the Port for the tagged address. Otherwise, if we can't find the target port, we will set the tagged address's port to 0 (it will still have the cluster IP set).
ishustava
force-pushed
the
tproxy-multiple-service-ports
branch
from
21e535c
to
807207b
Compare
ishustava
requested review from
a team,
kschoche and
thisisnotashwin
and removed request for
a team
ishustava
commented
May 4, 2021
|
|
||
| // clusterIPTaggedAddressName is the key for the tagged address to store the service's cluster IP and service port | ||
| // in Consul. Note: This value should not be changed without a corresponding change in Consul. | ||
| // TODO: change this to a constant shared with Consul to avoid accidentally changing this. |
There was a problem hiding this comment.
We will update it at a future time.
ishustava
force-pushed
the
tproxy-multiple-service-ports
branch
from
66c80cc
to
71fbb16
Compare
thisisnotashwin
approved these changes
May 4, 2021
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
* remove unnecessary cluster role usage for enterprise license templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we set a tagged address for each Kubernetes service port,
using the "virtual-" prefix for the tagged address key. For example,
if a service port is named "tcp", then we synced it to Consul with
the tagged address key "virtual-tcp".
However, since Consul doesn't really support multiple ports on a service yet,
this is unnecessary. So instead, we will find the service's target port
that is equal to the service port we are registering with Consul
and use that as the Port for the tagged address. Otherwise,
if we can't find the target port, we will set the tagged address's port to 0
(it will still have the cluster IP set).
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: