Revert temporary fixes to endpoints v2 tests #2971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were necessary to get tests to pass during the merge of several PRs across `consul` and `consul-k8s` but are no longer needed.
zalimeni
added
pr/no-changelog
|
@DanStough I'm guessing this was another merge-order / merge-conflict situation that's since resolved - my change to filter for TCP L4 ports would have made the commented test cases go from failing to passing. Repeat local runs look ok to me and flake seems less likely for the commented code, so I'm inclined to un-comment and assume this is stable. |
DanStough
approved these changes
Sep 19, 2023
|
@DanStough no sweat at all! I've had several "huh?" moments w/ tests this week myself, and I'd rather someone disable a test than let it stay broken, so thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were necessary to get tests to pass during the merge of several PRs across
consulandconsul-k8sbut are no longer needed.Changes proposed in this PR:
How I've tested this PR: Local + CI
How I expect reviewers to test this PR: 👓
Checklist: