Skip to content

Commit

Permalink
Revert temporary fixes to endpoints v2 tests (#2971)
Browse files Browse the repository at this point in the history
These were necessary to get tests to pass during the merge of several
PRs across `consul` and `consul-k8s` but are no longer needed.
  • Loading branch information
zalimeni authored Sep 19, 2023
1 parent a4616cf commit f662cf5
Showing 1 changed file with 16 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,9 @@ func TestReconcile_CreateService(t *testing.T) {
AppProtocol: &appProtocolGrpc,
},
{
Name: "other",
Port: 10001,
//Protocol: "TCP",
Name: "other",
Port: 10001,
Protocol: "TCP",
TargetPort: intstr.FromString("10001"),
// no app protocol specified
},
Expand Down Expand Up @@ -248,11 +248,11 @@ func TestReconcile_CreateService(t *testing.T) {
TargetPort: "my-grpc-port",
Protocol: pbcatalog.Protocol_PROTOCOL_GRPC,
},
//{
// VirtualPort: 10001,
// TargetPort: "10001",
// Protocol: pbcatalog.Protocol_PROTOCOL_TCP,
//},
{
VirtualPort: 10001,
TargetPort: "10001",
Protocol: pbcatalog.Protocol_PROTOCOL_TCP,
},
{
TargetPort: "mesh",
Protocol: pbcatalog.Protocol_PROTOCOL_MESH,
Expand Down Expand Up @@ -504,9 +504,9 @@ func TestReconcile_CreateService(t *testing.T) {
Ports: []corev1.ServicePort{
// Two L4 protocols on one exposed port
{
Name: "public-tcp",
Port: 8080,
//Protocol: "TCP",
Name: "public-tcp",
Port: 8080,
Protocol: "TCP",
TargetPort: intstr.FromString("my-svc-port"),
},
{
Expand Down Expand Up @@ -535,11 +535,11 @@ func TestReconcile_CreateService(t *testing.T) {
},
Data: common.ToProtoAny(&pbcatalog.Service{
Ports: []*pbcatalog.ServicePort{
//{
// VirtualPort: 8080,
// TargetPort: "my-svc-port",
// Protocol: pbcatalog.Protocol_PROTOCOL_TCP,
//},
{
VirtualPort: 8080,
TargetPort: "my-svc-port",
Protocol: pbcatalog.Protocol_PROTOCOL_TCP,
},
{
TargetPort: "mesh",
Protocol: pbcatalog.Protocol_PROTOCOL_MESH,
Expand Down

0 comments on commit f662cf5

Please sign in to comment.