Add session cleanup changes to CHANGELOG.md #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancluever
force-pushed
the
vancluever-changelog-session-cleanup
branch
from
1835f2c to
a7c8980
Compare
vancluever
force-pushed
the
vancluever-changelog-session-cleanup
branch
from
a7c8980 to
9934122
Compare
jefferai
previously approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Looks good. One comment: in the first bullet point, the last sentence could be seen to mean that workers won't close connections until the status update comes after connectivity is restored. Might be better to instead note that it will be cleaned up at that point, but will have already been closed.
|
I think I'm just going to strike that part as I think the extra context can be confusing, I can't seem to find a good way to explain it more without writing a book. 😜 I think just saying that the controller is now marking the connections closed like the worker does should be good enough. |
Co-authored-by: Jim <jlambert@hashicorp.com>
jimlambrt
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the changelog entries associated with the following PRs:
#1340
#1354
#1400
#1410