Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply extra review feedback from #1340 #1400

Merged
merged 9 commits into from
Jul 23, 2021
Merged

Apply extra review feedback from #1340 #1400

merged 9 commits into from
Jul 23, 2021

Conversation

vancluever
Copy link
Contributor

This PR applies review feedback made by @jefferai for #1340.

@vancluever vancluever requested a review from jefferai July 16, 2021 00:47
mgaffney
mgaffney previously approved these changes Jul 16, 2021
View reviewed changes
@vancluever vancluever mentioned this pull request Jul 16, 2021
Merged
jefferai
jefferai reviewed Jul 20, 2021
View reviewed changes
jefferai
jefferai requested changes Jul 20, 2021
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- just the one thing to change in the SQL query. Seems like either the as statements can be reverted or the rest of the select clause should be updated to use those values.

@mgaffney mgaffney mentioned this pull request Jul 21, 2021
Merged
@vancluever
Copy link
Contributor Author

@jefferai Now that @mgaffney has merged #1410, I think the other review comment is resolved?

@vancluever vancluever requested a review from jefferai July 22, 2021 16:35
@jefferai
Copy link
Member

Yep!

@vancluever vancluever merged commit 1ebb8ef into main Jul 23, 2021
@vancluever vancluever deleted the vancluever-1340-jefferai-feedback branch July 23, 2021 22:02
@vancluever vancluever mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai approved these changes

@mgaffney mgaffney mgaffney left review comments

Assignees
No one assigned
Labels
core/db core/servers core/session core/sql core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vancluever @jefferai @mgaffney