build: switch to Dependabot friendly dependency version notation #13132

jjohannes · 2024-05-07T18:58:45Z

Description:

Dependabot cannot understand Module Names. Thus we have to use the Maven coordinates when we define versions for it to pick them up correctly. Which is something we wanted to avoid initially. As a compromise, we add the Module Name of each dependency in the because statement. This way, you see both notations to avoid confusion. The updated java-module-dependencies plugin checks if the Module Names are correct (gradlex-org/java-module-dependencies#105).

Related issue(s):

Fixes #11570

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

github-actions · 2024-05-07T19:20:45Z

Node: HAPI Test (Restart) Results

2 tests 2 ✅ 8m 1s ⏱️
2 suites 0 💤
2 files 0 ❌

Results for commit 98d8185.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-07T19:21:51Z

Node: HAPI Test (Node Death Reconnect) Results

2 tests 2 ✅ 9m 21s ⏱️
2 suites 0 💤
2 files 0 ❌

Results for commit 98d8185.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-07T19:34:44Z

Node: HAPI Test (Token) Results

237 tests 235 ✅ 22m 9s ⏱️
17 suites 2 💤
17 files 0 ❌

Results for commit 98d8185.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-07T19:52:51Z

Node: HAPI Test (Crypto) Results

335 tests 335 ✅ 39m 27s ⏱️
25 suites 0 💤
25 files 0 ❌

Results for commit 98d8185.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-07T19:57:29Z

Node: HAPI Test (Misc) Results

468 tests 458 ✅ 40m 42s ⏱️
77 suites 10 💤
77 files 0 ❌

Results for commit 98d8185.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-07T20:08:28Z

Node: HAPI Test (Time Consuming) Results

21 tests 21 ✅ 53m 44s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit 98d8185.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-07T20:20:50Z

Node: Unit Test Results

2 319 files ±0 2 319 suites ±0 3h 4m 38s ⏱️ ±0s
119 054 tests ±0 118 987 ✅ ±0 67 💤 ±0 0 ❌ ±0
127 615 runs ±0 127 548 ✅ ±0 67 💤 ±0 0 ❌ ±0

Results for commit 98d8185. ± Comparison against base commit 24ef3ac.

This pull request removes 357 and adds 121 tests. Note that renamed tests count towards both.


  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [11] 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [203] Some Legal Characters 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [395] 
 Some Legal Characters
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [1] AddressBook {
   Address[id=0,nickname=0hdR11Qa,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=27357,hostnameExternal=219.241.144.88,portExternalIpv4=27357,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@74b39466,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@2bbbc4fd,memo=Ht0Z8kdk],
   Address[id=1,nickname=9wNXAj2V,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=4552,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@2b47778c, agrKeyPair=java.security.KeyPair@6cdb9133, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [2] AddressBook {
   Address[id=0,nickname=efY74fua,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=29632,hostnameExternal=164.37.214.144,portExternalIpv4=29632,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@704666bf,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@123561f2,memo=Cjj4xgbL],
   Address[id=3,nickname=ygnjNUyN,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=21566,hostnameExternal…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@2edd2bde, agrKeyPair=java.security.KeyPair@6ac7f481, sigCert=  [0]         Version: 3
         SerialNumber: 12482092706667292405
             IssuerDN: CN=s-aaaa
           Start Date: Sat Jan 01 00:00:00 UTC 2000
           Final Date: Fri Jan 01 00:00:00 UTC 2100
            SubjectDN: CN=s-aaaa
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
com.swirlds.platform.network.connectivity.InboundConnectionHandlerTest ‑ [1] AddressBook {
   Address[id=0,nickname=HnWJOF9z,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=47737,hostnameExternal=133.211.192.202,portExternalIpv4=47737,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@659684f5,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@2e7f9455,memo=pHNcJ5BE],
   Address[id=3,nickname=uz64LWEs,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=52598,hostnameExterna…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@445a4524, agrKeyPair=java.security.KeyPair@386a9641, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.network.connectivity.InboundConnectionHandlerTest ‑ [1] AddressBook {
   Address[id=0,nickname=Qg78HEw4,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=60363,hostnameExternal=251.29.208.41,portExternalIpv4=60363,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@4bfd925b,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@5b06c919,memo=TSEsokFU],
   Address[id=2,nickname=OldnDnxI,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=30200,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@4d123189, agrKeyPair=java.security.KeyPair@7eb03525, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
…

♻️ This comment has been updated with latest results.

github-actions · 2024-05-07T20:25:56Z

Node: HAPI Test (Smart Contract) Results

604 tests 604 ✅ 1h 25m 15s ⏱️
63 suites 0 💤
63 files 0 ❌

Results for commit 98d8185.

♻️ This comment has been updated with latest results.

codecov · 2024-05-16T06:36:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.21%. Comparing base (24ef3ac) to head (e3fed6d).

❗ Current head e3fed6d differs from pull request most recent head 98d8185

Please upload reports for the commit 98d8185 to get more accurate results.

Additional details and impacted files

@@              Coverage Diff               @@
##             develop   #13132       +/-   ##
==============================================
+ Coverage           0   67.21%   +67.21%     
- Complexity         0    36161    +36161     
==============================================
  Files              0     3700     +3700     
  Lines              0   148961   +148961     
  Branches           0    15501    +15501     
==============================================
+ Hits               0   100126   +100126     
- Misses             0    44505    +44505     
- Partials           0     4330     +4330

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

) Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com> Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>

jjohannes requested review from a team as code owners May 7, 2024 18:58

jjohannes requested review from matteriben and rbarker-dev May 7, 2024 18:58

jjohannes self-assigned this May 7, 2024

jjohannes force-pushed the 11570-dependabot-friendly-notation branch 2 times, most recently from e0567fc to 524374c Compare May 14, 2024 14:59

jjohannes requested review from nathanklick and hendrikebbers May 14, 2024 14:59

jjohannes force-pushed the 11570-dependabot-friendly-notation branch 2 times, most recently from d0900ed to 2e1647f Compare May 16, 2024 05:19

jjohannes force-pushed the 11570-dependabot-friendly-notation branch from 2e1647f to e3fed6d Compare May 16, 2024 13:47

chore: switch to Dependabot-friendly dependency version notation

98d8185

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>

jjohannes force-pushed the 11570-dependabot-friendly-notation branch from e3fed6d to 98d8185 Compare May 17, 2024 05:24

jjohannes removed the request for review from hendrikebbers May 17, 2024 05:24

JeffreyDallas approved these changes May 17, 2024

View reviewed changes

jeromy-cannon approved these changes May 20, 2024

View reviewed changes

jeromy-cannon merged commit 1ed6b62 into develop May 20, 2024
45 checks passed

jeromy-cannon deleted the 11570-dependabot-friendly-notation branch May 20, 2024 07:59

jjohannes mentioned this pull request Jun 3, 2024

build: Kotlin DSL / Convention Plugins / Java Modules hiero-ledger/hiero-sdk-java#1732

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: switch to Dependabot friendly dependency version notation #13132

build: switch to Dependabot friendly dependency version notation #13132

jjohannes commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

codecov bot commented May 16, 2024 •

edited

Loading

build: switch to Dependabot friendly dependency version notation #13132

build: switch to Dependabot friendly dependency version notation #13132

Conversation

jjohannes commented May 7, 2024 • edited Loading

github-actions bot commented May 7, 2024 • edited Loading

Node: HAPI Test (Restart) Results

github-actions bot commented May 7, 2024 • edited Loading

Node: HAPI Test (Node Death Reconnect) Results

github-actions bot commented May 7, 2024 • edited Loading

Node: HAPI Test (Token) Results

github-actions bot commented May 7, 2024 • edited Loading

Node: HAPI Test (Crypto) Results

github-actions bot commented May 7, 2024 • edited Loading

Node: HAPI Test (Misc) Results

github-actions bot commented May 7, 2024 • edited Loading

Node: HAPI Test (Time Consuming) Results

github-actions bot commented May 7, 2024 • edited Loading

Node: Unit Test Results

github-actions bot commented May 7, 2024 • edited Loading

Node: HAPI Test (Smart Contract) Results

codecov bot commented May 16, 2024 • edited Loading

Codecov Report

jjohannes commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

codecov bot commented May 16, 2024 •

edited

Loading