Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution to use this plugin in combination with Dependabot #105

Closed
jjohannes opened this issue May 7, 2024 · 1 comment
Closed

Solution to use this plugin in combination with Dependabot #105

jjohannes opened this issue May 7, 2024 · 1 comment
Labels
a:enhancement New feature or request

Comments

@jjohannes
Copy link
Member

Dependabot does not know how to deal with a build.gradle.kts file like this:

moduleInfo {
    version("com.fasterxml.jackson.core", "2.16.0")
    version("com.fasterxml.jackson.databind", "2.16.0")
    version("org.apache.commons.collections4", "4.4")
    version("org.apache.commons.math3", "1.15")
}

Instead, it would expect something this:

dependencies.constraints {
    api("com.fasterxml.jackson.core:jackson-core:2.16.0")
    api("com.fasterxml.jackson.core:jackson-databind:2.16.0")
    api("org.apache.commons:commons-collections4:4.4")
    api("org.apache.commons:commons-math3:3.6.1")
}

There is no way to teach Dependabot the custom notation (for this, it would need to be more customizable, dependabot/dependabot-core#1164). Maybe we can support some "mixed" notation that only uses Gradle standard notation that the plugin then checks for correctness:

dependencies.constraints {
    api("com.fasterxml.jackson.core:jackson-core:2.16.0") {
        because("com.fasterxml.jackson.core")
    }
    api("com.fasterxml.jackson.core:jackson-databind:2.16.0") {
        because("com.fasterxml.jackson.databind")
    }
    api("org.apache.commons:commons-collections4:4.4") {
        because("org.apache.commons.collections4")
    }
    api("org.apache.commons:commons-math3:3.6.1") {
        because("org.apache.commons.math3")
    }
}
@jjohannes
Copy link
Member Author

Solution because+warning implemented in 867b154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant