Lay foundation for validation of approximation #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have to update it all the time, which is tedious, and it's nowhere near the actually complicated code that would benefit from testing. If problems crop up, we can add back approximation tests, but for now, I think it's more important to have a clear path for the cleanups I'm working on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having some trouble in #1019, and as I found out, the reason is an invalid approximation. I have code in a local branch that validates the approximation (which is the reason I was able to find out). This validation code can't be merged yet, unfortunately. The reason for that is hard to explain, and at the same time not that interesting. The gist of it is, #97 is in the way.
#1019 addresses #97, but can't be merged yet, as I haven't fixed the problem yet. I'm working on it, but in the meantime, I'd like to get this PR merged. It contains as much of the validation work as is practical, along some associated cleanups of the approximation code.