Bound all edges by vertices #1019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
force-pushed
the
wip/edge
branch
4 times, most recently
from
a203973 to
0f96512
Compare
This makes circle and line representations consistent with each other, making lots of code redundant.
All edges are bound by vertices now, which removed the last special case that still required triangle representation.
|
This almost works! All tests pass and it looks good in the app, but I'm getting a nondescript export validation error. Gotta figure out what the problem is. |
This was referenced Sep 7, 2022
|
Closing in favor of #1057. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1020 for context.