Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pu/lookupfix #791

Merged
merged 10 commits into from
Aug 3, 2021
Merged

Pu/lookupfix #791

merged 10 commits into from
Aug 3, 2021

Conversation

izulin
Copy link
Collaborator

@izulin izulin commented Aug 2, 2021

Context

Fixes #787

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #791 (06ff3e5) into develop (b303691) will decrease coverage by 0.01%.
The diff coverage is 58.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #791      +/-   ##
===========================================
- Coverage    92.35%   92.34%   -0.02%     
===========================================
  Files          166      166              
  Lines        40339    40347       +8     
  Branches      3722     3719       -3     
===========================================
  Hits         37257    37257              
- Misses        3076     3084       +8     
  Partials         6        6              
Impacted Files Coverage Δ
src/Config.ts 98.63% <44.44%> (-0.27%) ⬇️
src/interpreter/binarySearch.ts 68.75% <66.66%> (-5.98%) ⬇️
src/Lookup/ColumnBinarySearch.ts 93.93% <100.00%> (+1.51%) ⬆️
src/Lookup/RowSearchStrategy.ts 85.00% <100.00%> (ø)

Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -6,7 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed
- `binarySearchThreshold` option is now deprecated, as every search of sorted data always uses binary search.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add deprecated tag to the binarySearchThreshold option description?
ie * @deprecated Every search of sorted data always uses binary search

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the Config?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it will be displayed in the API reference

@izulin izulin merged commit f411eba into develop Aug 3, 2021
@izulin izulin deleted the pu/lookupfix branch August 3, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants