Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vlookup approximate lookup not working #787

Closed
maadws opened this issue Jul 29, 2021 · 2 comments
Closed

Vlookup approximate lookup not working #787

maadws opened this issue Jul 29, 2021 · 2 comments
Assignees
Labels
Bug Something isn't working Verified Verified by Handsoncode

Comments

@maadws
Copy link

maadws commented Jul 29, 2021

Description

When vloopup last argument is true it still searches for exact results while in excel it searched for approximate results

Steps to reproduce

  1. add a lookup table with first column all numbers in sorted order
  2. add vlookup and search for a number inbetween
  3. no results
    check demo

Demo

https://codesandbox.io/s/competent-jackson-490o7?file=/src/hyperformulaConfig.js

Your environment

node10.15.3/chrome 92.0.4515.107(64bit)

  • HyperFormula version: 1.0.0
  • Browser Name and version: chrome 92.0.4515.107(64bit)
  • Operating System :windows 10
@maadws maadws added the Bug Something isn't working label Jul 29, 2021
@maadws
Copy link
Author

maadws commented Jul 29, 2021

The problem is related to this line it seems if binary search is used it forces exact matching. to work around it for now I made binarySearchThreshold = 1 in my config (also updated the demo)

@izulin izulin mentioned this issue Aug 2, 2021
7 tasks
@wojciechczerniak
Copy link
Contributor

Done in #791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Verified Verified by Handsoncode
Projects
None yet
Development

No branches or pull requests

3 participants