-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pu/lookupfix #791
Pu/lookupfix #791
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #791 +/- ##
===========================================
- Coverage 92.35% 92.34% -0.02%
===========================================
Files 166 166
Lines 40339 40347 +8
Branches 3722 3719 -3
===========================================
Hits 37257 37257
- Misses 3076 3084 +8
Partials 6 6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -6,7 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
## [Unreleased] | |||
|
|||
### Changed | |||
- `binarySearchThreshold` option is now deprecated, as every search of sorted data always uses binary search. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add deprecated
tag to the binarySearchThreshold
option description?
ie * @deprecated Every search of sorted data always uses binary search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the Config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it will be displayed in the API reference
Context
Fixes #787
How has this been tested?
Types of changes
Related issue(s):
Checklist: